mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] x86/config/efi: drop DRIVER_SERIAL_NS16550
Date: Tue, 20 Oct 2020 07:08:47 +0200	[thread overview]
Message-ID: <bb53e525-250d-4572-ba93-ec7ddd35b5cf@pengutronix.de> (raw)
In-Reply-To: <20200918110442.25159-2-u.kleine-koenig@pengutronix.de>

Hello Uwe,

On 9/18/20 1:04 PM, Uwe Kleine-König wrote:
> For most machines having DRIVER_SERIAL_NS16550 and DRIVER_SERIAL_EFI_STDIO
> both enabled results in the output appearing twice on the serial output.
> So remove disable the lowlevel driver and rely on the EFI bios for serial.

On the flip-side, some systems now won't output anything over serial with
the defconfig, like the one I just ran into. Maybe we should keep both
enabled, but have a quirk table, which boards to disable the 16550 for?

My board is
  EFI v2.40 by American Megatrends v327691". What's yours?
  barebox@barebox EFI payload:/ devinfo acpi-FACP0
  [...]
  Revision: 5
  OemId: ALASKA
  OemTableId: A M I
  OemRevision: 17244169
  CreatorId: 0x20494d41
  CreatorRevision: 65555

What's yours?
 
Cheers,
Ahmad

 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/x86/configs/efi_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/configs/efi_defconfig b/arch/x86/configs/efi_defconfig
> index 99bc39eaa6f1..83794d7a0702 100644
> --- a/arch/x86/configs/efi_defconfig
> +++ b/arch/x86/configs/efi_defconfig
> @@ -65,7 +65,6 @@ CONFIG_NET=y
>  CONFIG_NET_NFS=y
>  CONFIG_NET_NETCONSOLE=y
>  CONFIG_DRIVER_SERIAL_EFI_STDIO=y
> -CONFIG_DRIVER_SERIAL_NS16550=y
>  CONFIG_DRIVER_NET_EFI_SNP=y
>  # CONFIG_SPI is not set
>  CONFIG_DISK=y
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-10-20  5:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 11:04 [PATCH 1/2] Regenerate defconfig files Uwe Kleine-König
2020-09-18 11:04 ` [PATCH 2/2] x86/config/efi: drop DRIVER_SERIAL_NS16550 Uwe Kleine-König
2020-10-20  5:08   ` Ahmad Fatoum [this message]
2020-10-20  7:26     ` Uwe Kleine-König
2020-10-20  7:35       ` Ahmad Fatoum
2020-10-26 18:06         ` Michael Olbrich
2020-10-26 21:07           ` Ahmad Fatoum
2020-10-28  8:38             ` Sascha Hauer
2020-09-23  8:47 ` [PATCH 1/2] Regenerate defconfig files Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb53e525-250d-4572-ba93-ec7ddd35b5cf@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox