Re: [PATCH 5/5] lib: uncompress: add general zstd support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 14.07.22 10:45, Sascha Hauer wrote:
> On Wed, Jul 13, 2022 at 12:09:22PM +0200, Ahmad Fatoum wrote:
>> So far, we only supported zstd in squashfs and ubifs. Add support
>> everywhere else: In PBL for decompressing barebox proper, in uncompress
>> for compression arbitrary files and for bootm to decompress zstd
>> kernel images.
> 
> Have you tested this with the uncompress command?
> 
> a zstd compressed barebox works here, but using uncompress
> on a zstd compressed file results in:
> 
> ZSTD-compressed data is corrupt
> 
> or sometimes:
> 
> Out of memory while allocating ZSTD_DStream

I didn't test the uncompress command, no. How did you create
the zstd file? The Linux zstd decompression expects the size
to be trailing the decompressed data and doesn't parse the
zstd header. See the comment in scripts/Makefile.lib for details.

Cheers,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |