From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
barebox@lists.infradead.org
Cc: Bastian Krause <bst@pengutronix.de>
Subject: Re: [PATCH] common: let MACHINE_ID select SHA1
Date: Wed, 9 Feb 2022 10:32:21 +0100 [thread overview]
Message-ID: <c4e9f860-74cd-4054-5af6-b3a37a2fd064@pengutronix.de> (raw)
In-Reply-To: <20220209085125.177442-1-u.kleine-koenig@pengutronix.de>
On 09.02.22 09:51, Uwe Kleine-König wrote:
> SHA1 is a symbol that cannot be enabled manually and all other symbols
> needing it, select it:
>
> $ git grep -B3 -E '(depends on|select) SHA1\>' HEAD
> HEAD:common/Kconfig-config MACHINE_ID
> HEAD:common/Kconfig- bool "compute unique machine-id"
> HEAD:common/Kconfig- depends on FLEXIBLE_BOOTARGS
> HEAD:common/Kconfig: depends on SHA1
> --
> HEAD:crypto/Kconfig-
> HEAD:crypto/Kconfig-config DIGEST_SHA1_GENERIC
> HEAD:crypto/Kconfig- bool "SHA1"
> HEAD:crypto/Kconfig: select SHA1
> --
> HEAD:crypto/Kconfig-config DIGEST_SHA1_ARM
> HEAD:crypto/Kconfig- tristate "SHA1 digest algorithm (ARM-asm)"
> HEAD:crypto/Kconfig- depends on ARM
> HEAD:crypto/Kconfig: select SHA1
>
> Fixes: aada84e72e15 ("common: machine_id: introduce machine id generation")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
SHA1 is selected by either DIGEST_SHA1_GENERIC or DIGEST_SHA1_ARM.
I don't think this is correct.
> ---
> common/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index e540cba7ebaa..79f6afd8de85 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1042,7 +1042,7 @@ config RESET_SOURCE
> config MACHINE_ID
> bool "compute unique machine-id"
> depends on FLEXIBLE_BOOTARGS
> - depends on SHA1
> + select SHA1
> help
> Compute a persistent machine-specific id and store it to $global.machine_id.
> The id is a hash of device-specific information added via
>
> base-commit: f1077640937f6e8139463136edff215163465599
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-02-09 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 8:51 Uwe Kleine-König
2022-02-09 9:32 ` Ahmad Fatoum [this message]
2022-02-09 9:59 ` [PATCH] crypto: consistently name the algo digest symbols HAVE_DIGEST_ Uwe Kleine-König
2022-02-10 15:41 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e9f860-74cd-4054-5af6-b3a37a2fd064@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox