From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marcelo Politzer <marcelo.politzer@cartesi.io>
Cc: barebox@lists.infradead.org
Subject: Re: New RISCV board (cartesi-machine)
Date: Thu, 16 Sep 2021 23:21:44 +0200 [thread overview]
Message-ID: <c6139ced-b5c8-e74a-7a98-d14234ac2e72@pengutronix.de> (raw)
In-Reply-To: <CA+cd6D6ezjN3p_PRPkgq2q8ZmyjcL19S=5kqg14MFLEPAAV4wQ@mail.gmail.com>
Hi Marcelo,
On 16.09.21 20:01, Marcelo Politzer wrote:
>> Like this? :-)
>>
>> https://www.barebox.org/jsbarebox/
>
> That is cool!
:>
>>> OK, I'll clean this up and send it as two patches:
>>> - serial_sbi
>>> - cartesi (board)
>>
>> Sounds good.
>
> Patches attached, please review at your convenience.
Please resend without attachment if possible (e.g. with git send-email).
This makes it easier to review.
Some comments:
- Signed-off-by is required, just as with Linux. See https://developercertificate.org/
- A short commit message would be nice
- BOARD_CARTESI should depend on SOC_VIRT for uniformity with other boards
- Can you change device tree compatible? Generic boards should remain generic
and not contain vendor-specific stuff.
- Please add your new Kconfig options to virt64_defconfig. That way you can build
and use the same image for all Virt-based boards (You can still use a different
config in your BSP of course)
Serial driver:
- remove DEBUG defines
- depends on RISCV (otherwise there is no <asm/sbi.h>)
- You don't need to implement flush and setbrg
- ucb,htif0 is an unrelated device, but there is no device tree
node, you can bind to. You can register a device in sbi_init
and match against that. See riscv-timer for an example
- I don't understand the point of the ring buffer. A command would
be nice (e.g. This is needed, because SBI lacks a FIFO or such)
- to_priv unused
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-09-16 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:30 Marcelo Politzer
2021-09-15 21:17 ` Ahmad Fatoum
2021-09-15 21:43 ` Marcelo Politzer
2021-09-15 21:58 ` Ahmad Fatoum
2021-09-16 18:01 ` Marcelo Politzer
2021-09-16 21:21 ` Ahmad Fatoum [this message]
2021-09-20 19:41 ` Marcelo Politzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6139ced-b5c8-e74a-7a98-d14234ac2e72@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marcelo.politzer@cartesi.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox