mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org, rcz@pengutronix.de
Subject: Re: [PATCH v2 3/4] of: add generic of_fixup_machine_compatible()
Date: Wed, 27 Apr 2022 12:00:31 +0200	[thread overview]
Message-ID: <c683ab1b-c2bc-bffe-1339-38c23038c183@pengutronix.de> (raw)
In-Reply-To: <20220427095126.GB17577@pengutronix.de>

On 27.04.22 11:51, Oleksij Rempel wrote:
> On Wed, Apr 27, 2022 at 11:46:20AM +0200, Ahmad Fatoum wrote:
>> Hi,
>>
>> On 27.04.22 11:37, Oleksij Rempel wrote:
>>>  
>>> +	if (IS_ENABLED(CONFIG_MACHINE_FIXUP)) {
>>> +		const char *compat;
>>> +
>>> +		compat = getenv("global.of_machine_compatible");
>>> +		if (compat)
>>> +			of_fixup_machine_compatible(root, compat);
>>
>> That's not what I had in mind. I meant for the variable to affect bootspec
>> use, i.e. fixup barebox device tree. This here just adds an extra compatible
>> to the kernel device tree.
> 
> This is what is needed for my use case/customer. As soon as other use
> case will be needed, we can extend it.

Neither the name $global.of_machine_compatible nor the description
"Extra OF board compatible" suggest that this will fixup kernel DTs instead
of rewriting barebox' own machine compatible, which is what springs to
my mind when seeing this variable. I am fine if you only implement
what you need, but that name is unsuitable for your use case IMO.

> 
> Regards,
> Oleksij


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-04-27 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  9:37 [PATCH v2 0/4] add different OF board fixups Oleksij Rempel
2022-04-27  9:37 ` [PATCH v2 1/4] common: add $global.serial_number with device tree fixup Oleksij Rempel
2022-04-27  9:37 ` [PATCH v2 2/4] ARM: boards: protonic-imx6: make use of barebox_set_serial_number() Oleksij Rempel
2022-04-27  9:37 ` [PATCH v2 3/4] of: add generic of_fixup_machine_compatible() Oleksij Rempel
2022-04-27  9:46   ` Ahmad Fatoum
2022-04-27  9:51     ` Oleksij Rempel
2022-04-27 10:00       ` Ahmad Fatoum [this message]
2022-04-27  9:37 ` [PATCH v2 4/4] ARM: boards: skov-imx6: make use of of_fixup_machine_compatible() Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c683ab1b-c2bc-bffe-1339-38c23038c183@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    --cc=rcz@pengutronix.de \
    --subject='Re: [PATCH v2 3/4] of: add generic of_fixup_machine_compatible()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox