From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>, barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] common: boot: don't return too early in bootscript dryrun
Date: Mon, 14 Jun 2021 10:51:27 +0200 [thread overview]
Message-ID: <cefc5375-c35a-7e32-8cbe-557a3e87fa99@pengutronix.de> (raw)
In-Reply-To: <20210613222639.13190-1-marc@cpdesign.com.au>
Hi,
On 14.06.21 00:26, Marc Reilly wrote:
> A dryrun boot will now run the boot script and a then a
> dryrun of the bootm.
This would change behavior for boot scripts that directly boot
instead of setting up variables for bootm to use, but I think
that's acceptable,
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> ---
> common/boot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/boot.c b/common/boot.c
> index 07b67734d..183e6bb43 100644
> --- a/common/boot.c
> +++ b/common/boot.c
> @@ -77,7 +77,6 @@ static int bootscript_boot(struct bootentry *entry, int verbose, int dryrun)
>
> if (dryrun) {
> printf("Would run %s\n", bs->scriptpath);
> - return 0;
Maybe change message to reflect the new reality?
s/Would run/Running/
> }
>
> globalvar_add_simple("linux.bootargs.dyn.ip", NULL);
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-14 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 22:26 Marc Reilly
2021-06-13 22:26 ` [PATCH 2/4] ARM: beaglebone: add helper init script for checking if BBBW Marc Reilly
2021-06-15 9:11 ` Sascha Hauer
2021-06-13 22:26 ` [PATCH 3/4] ARM: am33xx: add define for 800Mhz MPU PLL point Marc Reilly
2021-06-15 9:14 ` Sascha Hauer
2021-06-13 22:26 ` [PATCH 4/4] ARM: beaglebone: init MPU speed to 800Mhz Marc Reilly
2021-06-14 8:51 ` Ahmad Fatoum [this message]
2021-06-15 5:31 ` [PATCH 1/4] common: boot: don't return too early in bootscript dryrun Marc Reilly
2021-06-15 8:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cefc5375-c35a-7e32-8cbe-557a3e87fa99@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox