From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] mci: omap: add new am335x and am437x SDHCI specific compatibles
Date: Tue, 7 Jul 2020 10:25:33 +0200 [thread overview]
Message-ID: <d1dc22ae-9311-5ed5-7c35-776e4b1665e1@pengutronix.de> (raw)
In-Reply-To: <20200707082243.5916-1-a.fatoum@pengutronix.de>
On 7/7/20 10:22 AM, Ahmad Fatoum wrote:
> For a while now, Linux has had a sdhci-omap driver for TI's OMAP SoCs
> making use of the SDHCI core library. This was in addition to the
> older omap-hsmmc driver, which didn't.
>
> Linux commit 0b4edf11187 ("ARM: dts: Move am33xx and am43xx mmc nodes to
> sdhci-omap driver") changes the device tree compatible of the mmc nodes
> on the am33xx and am43xx SoCs away from the omap-hsmmc to the SDHCI
> driver. Add the new compatibles, so we aren't broken by the change.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Hello Sascha,
>
> recent v5.8-rc3 sync breaks barebox SD/MMC use on OMAP3 and OMAP4 SoCs,
Correction: I don't really understand the naming scheme, but seems only
OMAP4 should be broken at the moment. (I tested on a beaglebone black)
> like the beaglebone. Please rebase the sync on this patch, so we avoid
> intermittent breakage..
>
> Cheers,
> Ahmad
> ---
> drivers/mci/omap_hsmmc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> index b14161032594..6623503cee06 100644
> --- a/drivers/mci/omap_hsmmc.c
> +++ b/drivers/mci/omap_hsmmc.c
> @@ -650,6 +650,12 @@ static __maybe_unused struct of_device_id omap_mmc_dt_ids[] = {
> }, {
> .compatible = "ti,omap4-hsmmc",
> .data = &omap4_data,
> + }, {
> + .compatible = "ti,am335-sdhci",
> + .data = &omap4_data,
> + }, {
> + .compatible = "ti,am437-sdhci",
> + .data = &omap4_data,
> }, {
> /* sentinel */
> }
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-07 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 8:22 Ahmad Fatoum
2020-07-07 8:25 ` Ahmad Fatoum [this message]
2020-07-11 4:19 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1dc22ae-9311-5ed5-7c35-776e4b1665e1@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox