mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Robin van der Gracht <robin@protonic.nl>, barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp compatible boards
Date: Thu, 12 Nov 2020 11:05:00 +0100	[thread overview]
Message-ID: <d4f6c8d4ffc0f6b6e08eb23fa33795cbab3720f5.camel@pengutronix.de> (raw)
In-Reply-To: <20201112100042.1853449-1-robin@protonic.nl>

On Thu, 2020-11-12 at 11:00 +0100, Robin van der Gracht wrote:
> The imx6q_ocotp_data struct is incomplete resulting in a crash when
> trying
> to read/blow fuses.
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  drivers/nvmem/ocotp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
> index 356e9bf11..cee50955e 100644
> --- a/drivers/nvmem/ocotp.c
> +++ b/drivers/nvmem/ocotp.c
> @@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
>  	.mac_offsets = { MAC_OFFSET_0 },
>  	.format_mac = imx_ocotp_format_mac,
>  	.set_timing = imx6_ocotp_set_timing,
> +	.fuse_blow = imx6_fuse_blow_addr,
> +	.fuse_read = imx6_fuse_read_addr,
>  };
>  
>  static struct imx_ocotp_data imx6sl_ocotp_data = {

Fixes: 17cba91885d9 ("nvmem: ocotp: read/write i.MX7 support")

Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

Thanks for the fix,
Rouven


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-11-12 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 10:00 [PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp " Robin van der Gracht
2020-11-12 10:05 ` Rouven Czerwinski [this message]
2020-11-12 11:12 ` [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4f6c8d4ffc0f6b6e08eb23fa33795cbab3720f5.camel@pengutronix.de \
    --to=r.czerwinski@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox