mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <>
To: "Uwe Kleine-König" <>
Subject: Re: [PATCH] arm: stm32mp15x: Move mmc aliases to board files
Date: Fri, 11 Mar 2022 10:31:16 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hello Uwe,

On 07.03.22 14:23, Uwe Kleine-König wrote:
> I would have gone with the mapping tables and I'd consider
> /aliases/barebox,mmc0 = ... more ugly. But I agree this to be
> a bit subjective.

Mapping table will be more effort IMO. At least the `barebox,` prefix
change would be mechanical and less error-prone.

>  If the soc-code continues to depend on having the mmc
> aliases as defined in stm32mp151.dtsi, there should be a comment
> describing that IMHO.

It's generic code that depends on the aliases for fixup.

>>>> Additionally having any alias at all ensures fixed naming that's
>>>> not dependent on probe order.
>>> Fine for me. And if the board doesn't define the aliases, you get random
>>> ordering.
>> I prefer sane defaults.
> I prefer sane defaults iff they can be easily adapted by board code. If
> you consider in board.dts:
> 	mmc0 = &sdmmc2;
> 	mmc1 = &sdmmc3;
> (for whatever reasons), you end up with mmc1 and mmc2 both pointing to
> sdmmc3. Ugly.

/delete-property/ is easily adaptable IMO, but yes, not particularly nice
to look at.

>> I think most people involved have boards (often with trivial board support)
>> that are not upstream. I do think we should avoid breaking them for no good
>> reason.
> I think these people should mainline their trivial board support if they
> want to be immune to such breaking.

One could hope. :-)


Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       |  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

barebox mailing list

      reply	other threads:[~2022-03-11  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 11:23 Uwe Kleine-König
2022-03-07 11:34 ` Ahmad Fatoum
2022-03-07 12:04   ` Uwe Kleine-König
2022-03-07 12:19     ` Ahmad Fatoum
2022-03-07 13:23       ` Uwe Kleine-König
2022-03-11  9:31         ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox