From: Robin van der Gracht <robin@protonic.nl> To: Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: Marco Felsch <m.felsch@pengutronix.de>, Sascha Hauer <sha@pengutronix.de>, Oleksij Rempel <linux@rempel-privat.de>, Oleksij Rempel <o.rempel@pengutronix.de>, barebox@lists.infradead.org, david@protonic.nl Subject: Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low Date: Mon, 20 Jun 2022 17:42:36 +0200 [thread overview] Message-ID: <dc804930a1d25f7aeefc2ab261ae375a@protonic.nl> (raw) In-Reply-To: <ead464cf-803f-5795-4269-7ff4d15cf9ed@pengutronix.de> Hello Ahmad, On 2022-06-20 09:51, Ahmad Fatoum wrote: > Hello, > > On 17.06.22 10:44, Marco Felsch wrote: >> On 22-06-17, Sascha Hauer wrote: >>>> Or, it is active low and your patch is correct :D >>> >>> If they are, can we add a comment or _N suffix to the names? >> >> Does barebox not have gpiod? The board code just should check if it is >> active or not. Whatever active means in this case. > > There is gpiod_get(), but there's also gpio-keys support. See > drivers/input/specialkeys.c for an example on how to register an input > notifier. I'm interested in two keys pressed at the same time. When I implement a notifyer like in specialkeys.c I'll have to check if the other key is pressed at that time as well. I noticed that the input subsystem is already maintaining a bitmask with keys pressed. If I tap into that, I can implement it like so: diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c index 8436903fd8..1e1a22ae8e 100644 --- a/arch/arm/boards/protonic-imx6/board.c +++ b/arch/arm/boards/protonic-imx6/board.c @@ -8,11 +8,13 @@ #include <bootm.h> #include <common.h> #include <deep-probe.h> +#include <dt-bindings/input/linux-event-codes.h> #include <environment.h> #include <fcntl.h> #include <globalvar.h> #include <gpio.h> #include <i2c/i2c.h> +#include <input/input.h> #include <mach/bbu.h> #include <mach/imx6.h> #include <mach/ocotp-fusemap.h> @@ -742,17 +744,13 @@ static int prt_imx6_init_kvg_yaco(struct prt_imx6_priv *priv) return prt_imx6_init_kvg_power(priv, PW_MODE_KVG_WITH_YACO); } -#define GPIO_KEY_F6 (0xe0 + 5) -#define GPIO_KEY_CYCLE (0xe0 + 2) - static int prt_imx6_init_prtvt7(struct prt_imx6_priv *priv) { - /* This function relies heavely on the gpio-pca9539 driver */ + unsigned long keys[BITS_TO_LONGS(KEY_CYCLEWINDOWS)]; - gpio_direction_input(GPIO_KEY_F6); - gpio_direction_input(GPIO_KEY_CYCLE); + input_key_get_status(keys, KEY_CYCLEWINDOWS); - if (gpio_get_value(GPIO_KEY_CYCLE) || gpio_get_value(GPIO_KEY_F6)) + if (!(test_bit(KEY_CYCLEWINDOWS, keys) && test_bit(KEY_F6, keys))) priv->no_usb_check = 1; return 0; - Robin
next prev parent reply other threads:[~2022-06-20 15:44 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 13:11 [PATCH 0/9] ARM: boards: protonic-imx6: Updates Robin van der Gracht 2022-06-16 13:11 ` [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low Robin van der Gracht 2022-06-16 16:28 ` Oleksij Rempel 2022-06-16 16:38 ` Oleksij Rempel 2022-06-17 6:57 ` Sascha Hauer 2022-06-17 8:44 ` Marco Felsch 2022-06-20 7:51 ` Ahmad Fatoum 2022-06-20 8:16 ` Robin van der Gracht 2022-06-20 15:42 ` Robin van der Gracht [this message] 2022-06-20 6:48 ` Robin van der Gracht 2022-06-20 7:23 ` Oleksij Rempel 2022-06-16 13:11 ` [PATCH 2/9] ARM: boards: protonic-imx6: Update comment to match a recent code update Robin van der Gracht 2022-06-17 7:00 ` Sascha Hauer 2022-06-20 6:40 ` Robin van der Gracht 2022-06-16 13:11 ` [PATCH 3/9] ARM: boards: protonic-imx6: Free allocated autoboot_timeout string Robin van der Gracht 2022-06-16 13:11 ` [PATCH 4/9] ARM: boards: protonic-imx6: Always free allocated alias string Robin van der Gracht 2022-06-16 13:11 ` [PATCH 5/9] ARM: boards: protonic-imx6: Remove unsused argument from prt_imx6_usb_mount Robin van der Gracht 2022-06-16 13:11 ` [PATCH 6/9] ARM: boards: protonic-imx6: Register prt-usb boot entry Robin van der Gracht 2022-06-16 13:11 ` [PATCH 7/9] ARM: boards: protonic-imx6: Remove usb_delay from the priv struct Robin van der Gracht 2022-06-16 13:11 ` [PATCH 8/9] ARM: boards: protonic-imx6: Read serial and mac from fuses if available Robin van der Gracht 2022-06-16 13:11 ` [PATCH 9/9] ARM: boards: protonic-imx6: Register serial_number parameter with ocotp Robin van der Gracht 2022-06-17 7:10 ` (subset) [PATCH 0/9] ARM: boards: protonic-imx6: Updates Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dc804930a1d25f7aeefc2ab261ae375a@protonic.nl \ --to=robin@protonic.nl \ --cc=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=david@protonic.nl \ --cc=linux@rempel-privat.de \ --cc=m.felsch@pengutronix.de \ --cc=o.rempel@pengutronix.de \ --cc=sha@pengutronix.de \ --subject='Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox