From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH] fixup-next: linux/nvmem-consumer.h: fix warning
Date: Wed, 31 Aug 2022 11:27:54 +0200 [thread overview]
Message-ID: <de957bed-44b6-b943-da5b-1d4f2714b799@pengutronix.de> (raw)
In-Reply-To: <20220831092614.68259-1-antonynpavlov@gmail.com>
On 31.08.22 11:26, Antony Pavlov wrote:
> This fixes the commit 06825a0ec35343a1
> ("nvmem: import Linux nvmem_cell_read_variable_le_u32")
> from the next branch.
Thanks!
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> The warning is:
>
> include/linux/nvmem-consumer.h:84:9: warning: returning 'void *' from a
> function with return type 'int' makes integer from pointer without a
> cast [-Wint-conversion]
> 84 | return ERR_PTR(-EOPNOTSUPP);
> | ^~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> include/linux/nvmem-consumer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
> index b461f840957..1fce7e1ae09 100644
> --- a/include/linux/nvmem-consumer.h
> +++ b/include/linux/nvmem-consumer.h
> @@ -81,7 +81,7 @@ static inline int nvmem_cell_read_variable_le_u32(struct device_d *dev,
> const char *cell_id,
> u32 *val)
> {
> - return ERR_PTR(-EOPNOTSUPP);
> + return -EOPNOTSUPP;
> }
>
> static inline int nvmem_cell_write(struct nvmem_cell *cell,
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-08-31 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 9:26 Antony Pavlov
2022-08-31 9:27 ` Ahmad Fatoum [this message]
2022-09-01 8:44 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de957bed-44b6-b943-da5b-1d4f2714b799@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox