mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrej Picej <andrej.picej@norik.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Cc: upstream@phytec.de
Subject: Re: [PATCH] ARM: pbab01: allow USB-OTG port runtime configuration
Date: Tue, 19 Apr 2022 13:57:01 +0200	[thread overview]
Message-ID: <e144b56b-3faf-fc85-c49f-47f474af9c50@norik.com> (raw)
In-Reply-To: <1ff138b7-0567-3d5a-8dae-400c58180ee1@pengutronix.de>

Hi Ahmad,

On 19. 04. 22 11:16, Ahmad Fatoum wrote:
> Hello Andrej,
> 
> On 19.04.22 10:39, Andrej Picej wrote:
>> Since commit a5a4c1d5a3 ("dts: update to v5.13-rc1"), which synced
>> kernel dts, USB-OTG port on phyFLEX board was set to work only in
>> peripheral mode. This has to do with phyFLEX baseboard hardware bug,
>> which prevents correct USB OTG ID pin detection in kernel code.
>>
>> Unlike linux kernel, barebox doesn't support OTG auto-detection mode via
>> ID pin. In barebox, user has to select desired USB mode of operation by
>> setting 'otg.mode' variable. Thus delete 'dr_mode' property from dts to
>> be able to later select USB OTG operating mode at runtime (either host
>> or peripheral).
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>>   arch/arm/dts/imx6qdl-phytec-pbab01.dtsi | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi b/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
>> index 991c7e4fab..36870facdd 100644
>> --- a/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
>> +++ b/arch/arm/dts/imx6qdl-phytec-pbab01.dtsi
>> @@ -15,6 +15,10 @@
>>   	status = "okay";
>>   };
>>   
>> +&usbotg {
>> +	/delete-property/ dr_mode;
>> +};
> 
> Wouldn't it be better to be explicit and set dr_mode = "otg"?
> It doesn't matter here, but some other USB controllers default
> to "host" in absence of the property, so setting it to "otg"
> will be clearer IMO.
> 

hm...yes, I think you are right. I will fix this and send a v2.

Thanks for your review.

Best regards,
Andrej

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2022-04-19 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  8:39 Andrej Picej
2022-04-19  9:16 ` Ahmad Fatoum
2022-04-19 11:57   ` Andrej Picej [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e144b56b-3faf-fc85-c49f-47f474af9c50@norik.com \
    --to=andrej.picej@norik.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=upstream@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox