mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>,
	Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org,
	"Leif Middelschulte" <leif.middelschulte@klsmartin.com>,
	uol@pengutronix.de, ore@pengutronix.de,
	"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH 6/6] ARM: configs: imx_v7_defconfig: enable some useful options
Date: Wed, 4 Jan 2023 13:04:59 +0100	[thread overview]
Message-ID: <f996bb72-f0a5-7219-c3bc-60a94aace222@pengutronix.de> (raw)
In-Reply-To: <20230104120119.GT11668@pengutronix.de>

On 04.01.23 13:01, Sascha Hauer wrote:
> On Fri, Dec 23, 2022 at 10:10:48AM +0100, Marco Felsch wrote:
>> Hi Ahmad,
>>
>> On 22-12-22, Ahmad Fatoum wrote:
>>> Give the defconfig some color by enabling console colors during startup,
>>> i.MX6 parallel LCD driver, backlight and some more options that were
>>> noticed missing during debugging a skov-imx6 issue.
>>
>> I'm okay with enabling a few command and the colored console per default
>> but the video-output use-case isn't really common and just increases the
>> size of the barebox image.
> 
> This patch indeed increases the binary size, like for example
> barebox-zii-vf610-dev.img from 743788 bytes to 790858 bytes.
> However, the enabled video options are only responsible for a small
> fraction of it. With disabling the video options again the image
> size shrinks to 788738 bytes.
> 
> I've always seen the imx_*_defconfig files as mostly full featured
> configs to get good compile coverage and a barebox that just works
> for as many cases as possible. From that perspective I think it's ok
> to add more options.

Feel free to pick 1-4/6 and I'll look again into 5-6 and resend
as appropriate.

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2023-01-04 12:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 14:11 [PATCH 0/6] ARM: i.MX6: Fix LVDS splash on skov and some others Ahmad Fatoum
2022-12-22 14:11 ` [PATCH 1/6] clk: imx: set CLK_SET_RATE_NO_REPARENT for all muxes Ahmad Fatoum
2022-12-23  9:11   ` Marco Felsch
2022-12-22 14:11 ` [PATCH 2/6] clk: mux: forward round/set rate to parent if CLK_SET_RATE_PARENT Ahmad Fatoum
2022-12-22 14:11 ` [PATCH 3/6] ARM: i.MX6: skov: refactor LVDS/parallel device tree fixups Ahmad Fatoum
2022-12-23  9:14   ` Marco Felsch
2022-12-22 14:11 ` [PATCH 4/6] ARM: i.MX6: skov: fix LVDS deep probe Ahmad Fatoum
2022-12-23  9:08   ` Marco Felsch
2022-12-22 14:12 ` [PATCH 5/6] video: edid: print debug message on EDID read out error Ahmad Fatoum
2022-12-23  9:06   ` Marco Felsch
2022-12-22 14:12 ` [PATCH 6/6] ARM: configs: imx_v7_defconfig: enable some useful options Ahmad Fatoum
2022-12-23  9:10   ` Marco Felsch
2023-01-04 12:01     ` Sascha Hauer
2023-01-04 12:04       ` Ahmad Fatoum [this message]
2023-01-04 12:07         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f996bb72-f0a5-7219-c3bc-60a94aace222@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=leif.middelschulte@klsmartin.com \
    --cc=m.felsch@pengutronix.de \
    --cc=ore@pengutronix.de \
    --cc=san@skov.dk \
    --cc=sha@pengutronix.de \
    --cc=uol@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox