mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] partitions: Increase MAX_PARTITION to 128
Date: Wed, 2 Jun 2021 11:20:34 +0200	[thread overview]
Message-ID: <ffbe48a3-94cc-aa79-98d7-38d152a26c4e@pengutronix.de> (raw)
In-Reply-To: <20210602071533.10093-1-s.hauer@pengutronix.de>

On 02.06.21 09:15, Sascha Hauer wrote:
> Having MAX_PARTITION defined to 8 is enough for a DOS partition table,
> but not for GPT. Increase it to the maximum GPT supports. It might be
> even better to allocate the partitions dynamically, but for nor take the
> easy way out.

Given that struct partition_desc is only ever dynamically allocated, I think
that's ok.

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviwed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  common/partitions/parser.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/partitions/parser.h b/common/partitions/parser.h
> index 8ad134a9aa..69508932b3 100644
> --- a/common/partitions/parser.h
> +++ b/common/partitions/parser.h
> @@ -11,7 +11,7 @@
>  #include <filetype.h>
>  #include <linux/list.h>
>  
> -#define MAX_PARTITION		8
> +#define MAX_PARTITION		128
>  #define MAX_PARTITION_NAME	38
>  
>  struct partition {
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-06-02  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  7:15 Sascha Hauer
2021-06-02  7:15 ` [PATCH 2/2] partitions: efi: Fix MAX_PARTITION check Sascha Hauer
2021-06-02  9:17   ` Ahmad Fatoum
2021-06-02  9:20 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffbe48a3-94cc-aa79-98d7-38d152a26c4e@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --subject='Re: [PATCH 1/2] partitions: Increase MAX_PARTITION to 128' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox