From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: barebox@lists.infradead.org
Subject: malloc() alignment on 32 bit
Date: Mon, 19 Sep 2022 14:37:59 +0200 [thread overview]
Message-ID: <ly7d1z1qvs.fsf@ensc-pc.intern.sigma-chemnitz.de> (raw)
Hello,
on an iMX6ull I stumpled across
| zstd_decomp_init:536 workspace=8ff1a004+161320
| ERROR: initcall ubifs_init+0x1/0xc4 failed: Invalid argument
which is caused by
| static int zstd_decomp_init(void)
| void *wksp = malloc(wksp_size);
| ...
| ZSTD_DCtx* ZSTD_initStaticDCtx(void *workspace, size_t workspaceSize)
| if ((size_t)workspace & 7) return NULL; /* 8-aligned */
Trivial fix would be 'memalign(8, wksp_size)', but is it really ok that
malloc() for 32 bit has only an alignment of 4?
Relevant code seems to be in common/tlsf.c
| enum tlsf_private
| {
| #if defined (TLSF_64BIT)
| /* All allocation sizes and addresses are aligned to 8 bytes. */
| ALIGN_SIZE_LOG2 = 3,
| #else
| /* All allocation sizes and addresses are aligned to 4 bytes. */
| ALIGN_SIZE_LOG2 = 2,
| #endif
'ldrd/strd' require 8 byte alignment which might break with such
alignment.
Enrico
next reply other threads:[~2022-09-19 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 12:37 Enrico Scholz [this message]
2022-09-19 13:33 ` Ahmad Fatoum
2022-09-19 13:57 ` Sascha Hauer
2022-09-19 14:24 ` Enrico Scholz
2022-09-20 7:36 ` Sascha Hauer
2022-09-28 10:24 ` Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ly7d1z1qvs.fsf@ensc-pc.intern.sigma-chemnitz.de \
--to=enrico.scholz@sigma-chemnitz.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox