Re: [PATCH] ARM: dts: rk3588-rock-5b: use broken-cd for sdmmc

[Yunus Taskopru <yunus@protonic.nl>]

Hello Ahmad,

At the moment, I am experiencing some hardware issues with the SD card 
slot, so I am unable to test whether the ROCK 5T workaround also works 
on the ROCK 5B.

Op 08-04-2026 om 3:59 p.m. schreef Ahmad Fatoum:
> Hello Yunus,
> 
> On 4/8/26 2:19 PM, Yunus Taskopru wrote:
>> Using the card-detect GPIO caused SD card access to fail on a tested
>> ROCK 5B.
>>
>> Replace the card-detect GPIO setup with broken-cd and drop the detect
>> pin from the sdmmc pinctrl configuration.
>>
>> Signed-off-by: Yunus Taskopru <yunus@protonic.nl>
> 
> This sound very similar to commit bd5518cd7e34 ("ARM: rockchip: fix SD
> card startup for Radxa ROCK 5T").
> 
> Optimally, we would support whatever is needed for the hardware chip
> select to work, so we can use the same pinmux as Linux.
> 
> Next best thing is that we don't have different workarounds for the same
> issue.
> 
> Can you check if the workaround in above commit also works for you if
> you add it into the ROCK 5b DT?
> 
> Thanks,
> Ahmad
> 
>> ---
>>   arch/arm/dts/rk3588-rock-5b.dts | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3588-rock-5b.dts b/arch/arm/dts/rk3588-rock-5b.dts
>> index aca675f57f..decece25d4 100644
>> --- a/arch/arm/dts/rk3588-rock-5b.dts
>> +++ b/arch/arm/dts/rk3588-rock-5b.dts
>> @@ -55,6 +55,12 @@ environment_sd: partition@408000 {
>>   	};
>>   };
>>   
>> +&sdmmc {
>> +	broken-cd;
>> +	/delete-property/ cd-gpios;
>> +	pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>;
>> +};
>> +
>>   &pcie3x4 {
>>   	/* Does not work in barebox (missing phy driver) */
>>   	status = "disabled";
> 

-- 
Yunus Taskopru
Protonic Holland.
tel.: +31 (0) 229 212928
De Factorij 36 / 1689 AL Zwaag