mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Yunus Taskopru <yunus@protonic.nl>
To: barebox@lists.infradead.org
Cc: Yunus Taskopru <yunus@protonic.nl>
Subject: [PATCH] ARM: dts: rk3588-rock-5b: use broken-cd for sdmmc
Date: Wed,  8 Apr 2026 14:19:12 +0200	[thread overview]
Message-ID: <20260408121912.1428585-1-yunus@protonic.nl> (raw)

Using the card-detect GPIO caused SD card access to fail on a tested
ROCK 5B.

Replace the card-detect GPIO setup with broken-cd and drop the detect
pin from the sdmmc pinctrl configuration.

Signed-off-by: Yunus Taskopru <yunus@protonic.nl>
---
 arch/arm/dts/rk3588-rock-5b.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/dts/rk3588-rock-5b.dts b/arch/arm/dts/rk3588-rock-5b.dts
index aca675f57f..decece25d4 100644
--- a/arch/arm/dts/rk3588-rock-5b.dts
+++ b/arch/arm/dts/rk3588-rock-5b.dts
@@ -55,6 +55,12 @@ environment_sd: partition@408000 {
 	};
 };
 
+&sdmmc {
+	broken-cd;
+	/delete-property/ cd-gpios;
+	pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>;
+};
+
 &pcie3x4 {
 	/* Does not work in barebox (missing phy driver) */
 	status = "disabled";
-- 
2.47.3




             reply	other threads:[~2026-04-08 12:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 12:19 Yunus Taskopru [this message]
2026-04-08 13:59 ` Ahmad Fatoum
2026-04-13 11:22   ` Yunus Taskopru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408121912.1428585-1-yunus@protonic.nl \
    --to=yunus@protonic.nl \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox