mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] bootm: include origin of device tree in verbose output
@ 2026-06-24  6:06 Ahmad Fatoum
  2026-06-29 10:27 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-06-24  6:06 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

To make it easier to see at a glance if the device tree to be passed to
Linux is barebox' own or an externally provided DT, include this
information into verbosity level 1.

Previously we only printed "using internal devicetree" at verbosity
level 2, but that's the same level we dump the whole DT, so we bump it
down a level and rename it to make it clear what the DT is internal to
(e.g. it's not a FIT-internal DT).

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/bootm.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/common/bootm.c b/common/bootm.c
index 26465875ad94..de1b87fe2072 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -328,13 +328,19 @@ void *bootm_get_devicetree(struct image_data *data)
 			return ERR_PTR(-EINVAL);
 		}
 
+		if (bootm_verbose(data))
+			printf("using %s as devicetree\n", data->oftree->name);
+
 	} else {
 		data->of_root_node = of_dup_root_node_for_boot();
-		if (!data->of_root_node)
+		if (!data->of_root_node) {
+			if (bootm_verbose(data))
+				printf("using no devicetree\n");
 			return NULL;
+		}
 
-		if (bootm_verbose(data) > 1)
-			printf("using internal devicetree\n");
+		if (bootm_verbose(data))
+			printf("using barebox's internal devicetree\n");
 	}
 
 	if (data->initrd_res) {
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bootm: include origin of device tree in verbose output
  2026-06-24  6:06 [PATCH] bootm: include origin of device tree in verbose output Ahmad Fatoum
@ 2026-06-29 10:27 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-06-29 10:27 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Wed, 24 Jun 2026 08:06:47 +0200, Ahmad Fatoum wrote:
> To make it easier to see at a glance if the device tree to be passed to
> Linux is barebox' own or an externally provided DT, include this
> information into verbosity level 1.
> 
> Previously we only printed "using internal devicetree" at verbosity
> level 2, but that's the same level we dump the whole DT, so we bump it
> down a level and rename it to make it clear what the DT is internal to
> (e.g. it's not a FIT-internal DT).
> 
> [...]

Applied, thanks!

[1/1] bootm: include origin of device tree in verbose output
      https://git.pengutronix.de/cgit/barebox/commit/?id=5f8f67f08dcf (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-29 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-24  6:06 [PATCH] bootm: include origin of device tree in verbose output Ahmad Fatoum
2026-06-29 10:27 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox