From: Lucas Stach <l.stach@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE
Date: Fri, 02 Oct 2020 13:26:03 +0200 [thread overview]
Message-ID: <1b203cf29de7969001d0ea9db8dd5b8dcc3e4759.camel@pengutronix.de> (raw)
In-Reply-To: <20201002105635.4662-3-m.felsch@pengutronix.de>
On Fr, 2020-10-02 at 12:56 +0200, Marco Felsch wrote:
> The imx23_defconfig, imx_v8_defconfig and imx_defconfig already
> selecting this config except for the imx_v7_defconfig. The
> imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610
> which select OFDEVICE. So it will be never selected if the
> MACH_ZII_VF610_DEV board support is dropped.
>
> Selecting the option here seems to be the better place instead of
> adding
> it to the imx_v7_defconfig because there are possible no i.MX6 boards
> not
> using the device tree.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> arch/arm/mach-imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index a1127e3707..a4b0f99e96 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -146,7 +146,7 @@ config ARCH_IMX6
> select ARCH_HAS_IMX_GPT
> select CPU_V7
> select PINCTRL_IMX_IOMUX_V3
> - select OFTREE
> + select OFDEVICE
Kconfig selects are not recursive, so you still need to keep the OFTREE
select here, otherwise you might end up with a broken dependency for
OFDEVICE.
Regards,
Lucas
> select COMMON_CLK_OF_PROVIDER
> select HW_HAS_PCI
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-10-02 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 10:56 [PATCH 1/3] ARM: cm-fx6: fix build dependency Marco Felsch
2020-10-02 10:56 ` [PATCH 2/3] ARM: i.MX6X: cleanup " Marco Felsch
2020-10-02 10:56 ` [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE Marco Felsch
2020-10-02 11:26 ` Lucas Stach [this message]
2020-10-02 13:32 ` Marco Felsch
2020-10-05 7:13 ` [PATCH 1/3] ARM: cm-fx6: fix build dependency Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b203cf29de7969001d0ea9db8dd5b8dcc3e4759.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox