mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE
Date: Fri, 2 Oct 2020 15:32:17 +0200	[thread overview]
Message-ID: <20201002133217.afkkdngxfehoesvo@pengutronix.de> (raw)
In-Reply-To: <1b203cf29de7969001d0ea9db8dd5b8dcc3e4759.camel@pengutronix.de>

On 20-10-02 13:26, Lucas Stach wrote:
> On Fr, 2020-10-02 at 12:56 +0200, Marco Felsch wrote:
> > The imx23_defconfig, imx_v8_defconfig and imx_defconfig already
> > selecting this config except for the imx_v7_defconfig. The
> > imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610
> > which select OFDEVICE. So it will be never selected if the
> > MACH_ZII_VF610_DEV board support is dropped.
> > 
> > Selecting the option here seems to be the better place instead of
> > adding
> > it to the imx_v7_defconfig because there are possible no i.MX6 boards
> > not
> > using the device tree.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  arch/arm/mach-imx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index a1127e3707..a4b0f99e96 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -146,7 +146,7 @@ config ARCH_IMX6
> >  	select ARCH_HAS_IMX_GPT
> >  	select CPU_V7
> >  	select PINCTRL_IMX_IOMUX_V3
> > -	select OFTREE
> > +	select OFDEVICE
> 
> Kconfig selects are not recursive, so you still need to keep the OFTREE
> select here, otherwise you might end up with a broken dependency for
> OFDEVICE.

I checked the Kbuild docu and found:
https://www.kernel.org/doc/html/latest/kbuild/issues.html, #Issue1.
This example shows that select is recursive. The documentations also
points out that select don't check the depends on. So this change seems
to be valid since OFDEVICE don't has any dependcies.

Regards,
  Marco

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-10-02 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 10:56 [PATCH 1/3] ARM: cm-fx6: fix build dependency Marco Felsch
2020-10-02 10:56 ` [PATCH 2/3] ARM: i.MX6X: cleanup " Marco Felsch
2020-10-02 10:56 ` [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE Marco Felsch
2020-10-02 11:26   ` Lucas Stach
2020-10-02 13:32     ` Marco Felsch [this message]
2020-10-05  7:13 ` [PATCH 1/3] ARM: cm-fx6: fix build dependency Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002133217.afkkdngxfehoesvo@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    --subject='Re: [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox