Re: [PATCH 2/2] i.MX: HAB: update text for HABV4_CSF_UNLOCK_UID

[Fabian Pflug <f.pflug@pengutronix.de>]

Hey,

On Mon, 2026-04-13 at 10:21 +0200, Jonas Rebmann wrote:
> On 2026-03-30 14:24, Fabian Pflug wrote:
> > With the establishment of global.soc_uid_bin, there is no need to look
> > for the serial number and reverse it.
> 
> I don't believe reverting the byte order manually is something we were
> supposed to be doing before.

It needed to be done in order for it to work. If it was supposed to done like that I can't tell, but it is what was
needed.

> 
> > Also some SoC's will have 128-bit UID's, so the hint to 64 bit is not
> > correct and should be removed.
> > 
> > Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
> > ---
> >   arch/arm/mach-imx/Kconfig | 11 +++--------
> >   1 file changed, 3 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index 2e4d1ac80a..bfcb6ae402 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -918,17 +918,12 @@ config HABV4_CSF_UNLOCK_UID
> >   	depends on HABV4 && HABV4_CSF_UNLOCK_FIELD_RETURN
> >   	string "CSF Unlock UID"
> >   	help
> > -	  Device specific 64-bit UID required to unlock the field-return
> > +	  Device specific UID required to unlock the field-return
> >   	  feature. This value must match the per device UNIQUE_ID fuses.
> >   
> >   	  The below example shows the expected format. The UNIQUE_ID is
> > -	  printed during boot by barebox:
> > -	    i.MX___ unique ID: 7766554433221100
> > -	  or it can be queried by Linux via:
> > -	    - cat /sys/devices/soc0/serial_number
> > -	      7766554433221100
> > -
> > -	  So this value have to be set:
> > +	  is stored in $global.soc_uid_bin, but must be split into bytes.
> 
> "The UNIQUE_ID is is stored"?

Thanks, fixed.

> 
> > +	  The soc_uid_bin 0011223344556677 becomes:
> >   	    - 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77
> 
> I never used this feature but is there any good reason why this should
> consume a different format from what $global.soc_uid_bin returns?

HAB_CSF_UNLOCK_UID does not like a single 64 bit value, but instead needs the byte representation.
TLV on the other hand needs the single 64bi value. So either one needs to be converted, or you need to introduce another
value soc_uid_hex_bytes, but at what point is it overkill?

Fabian

> 
> >   	  Afterwards, the `hab -p -r` command can be used to burn the fuse.
> >