Re: [PATCH 1/2] common: misc: add soc_uid_bin to globalvar

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 3/30/26 2:24 PM, Fabian Pflug wrote:
> uidstr and uidbuf could be the same, but don't have to be. This results
> in uncertainty on what exactly is the current UID used for
> machine_set_hashable and to compare against with TLV.
> 
> Add an additional global var, that represents a binary representation
> of the soc_uid_bin variable.
> 
> This can now be used to feed as data for bound-soc-uid into
> `bareboxtlv-generator.py` or as the value for
> `CONFIG_HABV4_CSF_UNLOCK_UID`
> 
> Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
> ---
>  common/misc.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/common/misc.c b/common/misc.c
> index ecf9574f7a..f18c8b5825 100644
> --- a/common/misc.c
> +++ b/common/misc.c
> @@ -268,6 +268,7 @@ const uuid_t *barebox_get_product_uuid(void)
>  BAREBOX_MAGICVAR(global.product.uuid, "SMBIOS-reported product UUID");
>  
>  static char *soc_uid_str;
> +static char *soc_uid_bin_str;
>  static void *soc_uid;
>  static size_t soc_uid_len;
>  
> @@ -295,16 +296,19 @@ void barebox_set_soc_uid(const char *uidstr, const void *uidbuf, size_t len)
>  	soc_uid = xmemdup(uidbuf, len);
>  	soc_uid_len = len;
>  
> +	soc_uid_bin_str = xzalloc(len * 2 + 1);
> +	bin2hex(soc_uid_bin_str, uidbuf, len);
> +
>  	if (uidstr) {
>  		soc_uid_str = xstrdup(uidstr);
>  	} else {
> -		soc_uid_str = xzalloc(len * 2 + 1);
> -		bin2hex(soc_uid_str, uidbuf, len);
> +		soc_uid_str = soc_uid_bin_str;
>  	}
>  
>  	machine_id_set_hashable(uidbuf, len);
>  
>  	globalvar_add_simple_string("soc_uid", &soc_uid_str);
> +	globalvar_add_simple_string("soc_uid_bin", &soc_uid_bin_str);

I suggest renaming to soc_uid_hex.

Cheers,
Ahmad

>  }
>  BAREBOX_MAGICVAR(global.soc_uid, "SoC Unique ID");
>  
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |