From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Juergen Borleis <jbe@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: webasto-ccbv2: consider the available memory size for optee
Date: Tue, 22 Feb 2022 12:15:08 +0100 [thread overview]
Message-ID: <1f96058d-fb82-c834-08ae-8b9915201286@pengutronix.de> (raw)
In-Reply-To: <20220222104859.44391-1-jbe@pengutronix.de>
Hi,
On 22.02.22 11:48, Juergen Borleis wrote:
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
Not that I object, but why does it matter?
It's a heuristic anyway. The only reason why it needs two entry
points is a limitation of the build system (only DCD table differs
here, but barebox build needs a distinct entry point for each
image).
Cheers,
Ahmad
> ---
> arch/arm/boards/webasto-ccbv2/lowlevel.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boards/webasto-ccbv2/lowlevel.c b/arch/arm/boards/webasto-ccbv2/lowlevel.c
> index 32117b0..84de271 100644
> --- a/arch/arm/boards/webasto-ccbv2/lowlevel.c
> +++ b/arch/arm/boards/webasto-ccbv2/lowlevel.c
> @@ -32,7 +32,7 @@ static void configure_uart(void)
>
> }
>
> -static void noinline start_ccbv2(u32 r0)
> +static void noinline start_ccbv2(u32 r0, unsigned long memSize)
> {
> int tee_size;
> void *tee;
> @@ -48,7 +48,7 @@ static void noinline start_ccbv2(u32 r0)
> */
> if(IS_ENABLED(CONFIG_FIRMWARE_CCBV2_OPTEE)
> && !(r0 > MX6_MMDC_P0_BASE_ADDR
> - && r0 < MX6_MMDC_P0_BASE_ADDR + SZ_512M)) {
> + && r0 < MX6_MMDC_P0_BASE_ADDR + memSize)) {
> get_builtin_firmware(ccbv2_optee_bin, &tee, &tee_size);
>
> memset((void *)OPTEE_OVERLAY_LOCATION, 0, 0x1000);
> @@ -70,7 +70,7 @@ ENTRY_FUNCTION(start_imx6ul_ccbv2_256m, r0, r1, r2)
> setup_c();
> barrier();
>
> - start_ccbv2(r0);
> + start_ccbv2(r0, SZ_256M);
> }
>
> ENTRY_FUNCTION(start_imx6ul_ccbv2_512m, r0, r1, r2)
> @@ -84,5 +84,5 @@ ENTRY_FUNCTION(start_imx6ul_ccbv2_512m, r0, r1, r2)
> setup_c();
> barrier();
>
> - start_ccbv2(r0);
> + start_ccbv2(r0, SZ_512M);
> }
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-02-22 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 10:48 Juergen Borleis
2022-02-22 10:48 ` [PATCH 2/3] ARM: webasto-marvel: add device tree shared with the kernel Juergen Borleis
2022-02-22 10:48 ` [PATCH 3/3] ARM: webasto-marvel: share the run-time setup with the ccbv2 variant Juergen Borleis
2022-02-22 11:19 ` Ahmad Fatoum
2022-02-22 14:13 ` Oleksij Rempel
2022-02-22 11:15 ` Ahmad Fatoum [this message]
2022-02-23 11:36 ` [PATCH 1/3] ARM: webasto-ccbv2: consider the available memory size for optee Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f96058d-fb82-c834-08ae-8b9915201286@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox