From: Oleksij Rempel <linux@rempel-privat.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Juergen Borleis <jbe@pengutronix.de>,
barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: webasto-marvel: share the run-time setup with the ccbv2 variant
Date: Tue, 22 Feb 2022 15:13:59 +0100 [thread overview]
Message-ID: <628ee195-3c15-882e-84ca-bb5ecdd25450@rempel-privat.de> (raw)
In-Reply-To: <1ef7b4b9-21e2-54ac-409e-792e3656fe0b@pengutronix.de>
Am 22.02.22 um 12:19 schrieb Ahmad Fatoum:
> On 22.02.22 11:48, Juergen Borleis wrote:
>> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
>> ---
>> arch/arm/boards/webasto-ccbv2/board.c | 6 +++++-
>> arch/arm/boards/webasto-ccbv2/lowlevel.c | 24 ++++++++++++++++++------
>> images/Makefile.imx | 2 ++
>> 3 files changed, 25 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boards/webasto-ccbv2/board.c b/arch/arm/boards/webasto-ccbv2/board.c
>> index 4777713..fd6ea6f 100644
>> --- a/arch/arm/boards/webasto-ccbv2/board.c
>> +++ b/arch/arm/boards/webasto-ccbv2/board.c
>> @@ -22,7 +22,10 @@ static int ccbv2_probe(struct device_d *dev)
>> imx6_bbu_internal_mmcboot_register_handler("emmc", "/dev/mmc1",
>> BBU_HANDLER_FLAG_DEFAULT);
>>
>> - barebox_set_hostname("weabsto-ccbv2");
>> + if (of_machine_is_compatible("webasto,imx6ul-marvel"))
>> + barebox_set_hostname("webasto-marvel");
>
> Nitpick: barebox_set_hostname(device_get_match_data(dev));
If host name is not set by board code, it will be automatically generated by barebox from devicetree
compatible.
--
Regards,
Oleksij
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-02-22 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 10:48 [PATCH 1/3] ARM: webasto-ccbv2: consider the available memory size for optee Juergen Borleis
2022-02-22 10:48 ` [PATCH 2/3] ARM: webasto-marvel: add device tree shared with the kernel Juergen Borleis
2022-02-22 10:48 ` [PATCH 3/3] ARM: webasto-marvel: share the run-time setup with the ccbv2 variant Juergen Borleis
2022-02-22 11:19 ` Ahmad Fatoum
2022-02-22 14:13 ` Oleksij Rempel [this message]
2022-02-22 11:15 ` [PATCH 1/3] ARM: webasto-ccbv2: consider the available memory size for optee Ahmad Fatoum
2022-02-23 11:36 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628ee195-3c15-882e-84ca-bb5ecdd25450@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox