mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] kbuild: add $(always-y) to 'targets'
@ 2020-04-30  4:42 Masahiro Yamada
  2020-05-04  6:43 ` Sascha Hauer
  2020-05-04 11:27 ` Masahiro Yamada
  0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-04-30  4:42 UTC (permalink / raw)
  To: barebox; +Cc: Masahiro Yamada

I missed to sync this line in commit 421108c51da4 ("kbuild: rename
hostprogs-y/always to hostprogs/always-y").

Since then, the files in always(-y) are needlessly rebuilt.

Fixes: 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/Makefile.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 8c28ccb8e..acb0d68b8 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE
 	$(call if_changed_dep,as_o_S)
 
 targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y)
-targets += $(extra-y) $(MAKECMDGOALS) $(always)
+targets += $(extra-y) $(always-y) $(MAKECMDGOALS)
 
 # Linker scripts preprocessor (.lds.S -> .lds)
 # ---------------------------------------------------------------------------
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: add $(always-y) to 'targets'
  2020-04-30  4:42 [PATCH] kbuild: add $(always-y) to 'targets' Masahiro Yamada
@ 2020-05-04  6:43 ` Sascha Hauer
  2020-05-04 11:27 ` Masahiro Yamada
  1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2020-05-04  6:43 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: barebox

On Thu, Apr 30, 2020 at 01:42:51PM +0900, Masahiro Yamada wrote:
> I missed to sync this line in commit 421108c51da4 ("kbuild: rename
> hostprogs-y/always to hostprogs/always-y").
> 
> Since then, the files in always(-y) are needlessly rebuilt.
> 
> Fixes: 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Applied, thanks

Sascha

> 
>  scripts/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8c28ccb8e..acb0d68b8 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE
>  	$(call if_changed_dep,as_o_S)
>  
>  targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y)
> -targets += $(extra-y) $(MAKECMDGOALS) $(always)
> +targets += $(extra-y) $(always-y) $(MAKECMDGOALS)
>  
>  # Linker scripts preprocessor (.lds.S -> .lds)
>  # ---------------------------------------------------------------------------
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: add $(always-y) to 'targets'
  2020-04-30  4:42 [PATCH] kbuild: add $(always-y) to 'targets' Masahiro Yamada
  2020-05-04  6:43 ` Sascha Hauer
@ 2020-05-04 11:27 ` Masahiro Yamada
  2020-05-05  5:42   ` Sascha Hauer
  1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2020-05-04 11:27 UTC (permalink / raw)
  To: Barebox List

On Thu, Apr 30, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> I missed to sync this line in commit 421108c51da4 ("kbuild: rename
> hostprogs-y/always to hostprogs/always-y").
>
> Since then, the files in always(-y) are needlessly rebuilt.

This line is not precise because the files in $(always) are fine.
If it is not too late, could you please reword this line as follows ?


Since then, the files in $(always-y) are needlessly rebuilt.








>
> Fixes: 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  scripts/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8c28ccb8e..acb0d68b8 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE
>         $(call if_changed_dep,as_o_S)
>
>  targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y)
> -targets += $(extra-y) $(MAKECMDGOALS) $(always)
> +targets += $(extra-y) $(always-y) $(MAKECMDGOALS)
>
>  # Linker scripts preprocessor (.lds.S -> .lds)
>  # ---------------------------------------------------------------------------
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: add $(always-y) to 'targets'
  2020-05-04 11:27 ` Masahiro Yamada
@ 2020-05-05  5:42   ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2020-05-05  5:42 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Barebox List

On Mon, May 04, 2020 at 08:27:43PM +0900, Masahiro Yamada wrote:
> On Thu, Apr 30, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > I missed to sync this line in commit 421108c51da4 ("kbuild: rename
> > hostprogs-y/always to hostprogs/always-y").
> >
> > Since then, the files in always(-y) are needlessly rebuilt.
> 
> This line is not precise because the files in $(always) are fine.
> If it is not too late, could you please reword this line as follows ?
> 
> 
> Since then, the files in $(always-y) are needlessly rebuilt.

Sorry, it's too late. I merged this as a fix to master.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-05  5:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30  4:42 [PATCH] kbuild: add $(always-y) to 'targets' Masahiro Yamada
2020-05-04  6:43 ` Sascha Hauer
2020-05-04 11:27 ` Masahiro Yamada
2020-05-05  5:42   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox