mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! kbuild: unify barebox and pbl build commands
@ 2020-05-21 16:12 Masahiro Yamada
  2020-05-25  6:52 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-05-21 16:12 UTC (permalink / raw)
  To: barebox; +Cc: Masahiro Yamada

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

Sascha,

Some redundant code slipped in.

Could you please squash this into the preivous
"kbuild: unify barebox and pbl build commands" ?


 scripts/Makefile.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 31341d23c..ed2bb28c5 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -117,7 +117,7 @@ cmd_cc_i_c       = $(CPP) $(c_flags)   -o $@ $<
 # (See cmd_cc_o_c + relevant part of rule_cc_o_c)
 
 quiet_cmd_cc_o_c = CC $(quiet_modtag)  $@
-      cmd_cc_o_c = $(CC) $(c_flags) $(if $(part-of-pbl),-D__PBL__ $(PBL_CPPFLAGS)) -c -o $@ $<
+      cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $<
 
 define rule_cc_o_c
 	$(call cmd,checksrc)
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fixup! kbuild: unify barebox and pbl build commands
  2020-05-21 16:12 [PATCH] fixup! kbuild: unify barebox and pbl build commands Masahiro Yamada
@ 2020-05-25  6:52 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-05-25  6:52 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: barebox

On Fri, May 22, 2020 at 01:12:11AM +0900, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
> Sascha,
> 
> Some redundant code slipped in.
> 
> Could you please squash this into the preivous
> "kbuild: unify barebox and pbl build commands" ?

Did that, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-25  6:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 16:12 [PATCH] fixup! kbuild: unify barebox and pbl build commands Masahiro Yamada
2020-05-25  6:52 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox