mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] devinfo: print device parent along with device info
@ 2020-06-19 14:03 Ahmad Fatoum
  2020-06-23  7:57 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-06-19 14:03 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Especially for "virtual" devices (e.g. wdog0 or mmc2), it is often
useful to know the corresponding hardware device.

Instead of always having to search through plain devinfo, just
include this information in the output when running
`devinfo device`.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 commands/devinfo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/commands/devinfo.c b/commands/devinfo.c
index 81956b1cc099..2e2e48e42cc5 100644
--- a/commands/devinfo.c
+++ b/commands/devinfo.c
@@ -85,6 +85,9 @@ static int do_devinfo(int argc, char *argv[])
 		if (dev->info)
 			dev->info(dev);
 
+		if (dev->parent)
+			printf("Parent: %s\n", dev_name(dev->parent));
+
 		first = true;
 		list_for_each_entry(param, &dev->parameters, list) {
 			if (first) {
-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] devinfo: print device parent along with device info
  2020-06-19 14:03 [PATCH] devinfo: print device parent along with device info Ahmad Fatoum
@ 2020-06-23  7:57 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-06-23  7:57 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Fri, Jun 19, 2020 at 04:03:53PM +0200, Ahmad Fatoum wrote:
> Especially for "virtual" devices (e.g. wdog0 or mmc2), it is often
> useful to know the corresponding hardware device.
> 
> Instead of always having to search through plain devinfo, just
> include this information in the output when running
> `devinfo device`.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  commands/devinfo.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/commands/devinfo.c b/commands/devinfo.c
> index 81956b1cc099..2e2e48e42cc5 100644
> --- a/commands/devinfo.c
> +++ b/commands/devinfo.c
> @@ -85,6 +85,9 @@ static int do_devinfo(int argc, char *argv[])
>  		if (dev->info)
>  			dev->info(dev);
>  
> +		if (dev->parent)
> +			printf("Parent: %s\n", dev_name(dev->parent));
> +
>  		first = true;
>  		list_for_each_entry(param, &dev->parameters, list) {
>  			if (first) {
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-23  7:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 14:03 [PATCH] devinfo: print device parent along with device info Ahmad Fatoum
2020-06-23  7:57 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox