mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] kvx: remove duplicated dtb symbols
@ 2020-06-30 20:53 Clement Leger
  2020-07-01  5:23 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Clement Leger @ 2020-06-30 20:53 UTC (permalink / raw)
  To: Sascha Hauer, barebox; +Cc: Clement Leger

dtb symbols (__dtb_start, __dtb_end) are already defined using
RO_DATA_SECTION. This duplicated dtb section is a leftover used by
Kalray internal tools to patch the dtb when loading the elf on a
target. Remove it to keep only one symbol definition.

Signed-off-by: Clement Leger <cleger@kalray.eu>
---
 arch/kvx/cpu/barebox.lds.S | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/kvx/cpu/barebox.lds.S b/arch/kvx/cpu/barebox.lds.S
index bf92564cf..77ebaf0ae 100644
--- a/arch/kvx/cpu/barebox.lds.S
+++ b/arch/kvx/cpu/barebox.lds.S
@@ -10,8 +10,6 @@
 OUTPUT_FORMAT("elf64-kvx")
 OUTPUT_ARCH("kvx:kv3-1:64")
 
-#define DTB_DEFAULT_SIZE	(24 * 1024)
-
 SECTIONS
 {
 	. = CONFIG_ARCH_TEXT_BASE;
@@ -54,13 +52,6 @@ SECTIONS
 		RO_DATA_SECTION
 	}
 
-	.dtb ALIGN(16):
-	{
-		__dtb_start = .;
-		. += DTB_DEFAULT_SIZE;
-		__dtb_end = .;
-	}
-
 	_etext = .; /* End of text and rodata section */
 
 	.data ALIGN(4): {
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kvx: remove duplicated dtb symbols
  2020-06-30 20:53 [PATCH] kvx: remove duplicated dtb symbols Clement Leger
@ 2020-07-01  5:23 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-07-01  5:23 UTC (permalink / raw)
  To: Clement Leger; +Cc: barebox

On Tue, Jun 30, 2020 at 10:53:44PM +0200, Clement Leger wrote:
> dtb symbols (__dtb_start, __dtb_end) are already defined using
> RO_DATA_SECTION. This duplicated dtb section is a leftover used by
> Kalray internal tools to patch the dtb when loading the elf on a
> target. Remove it to keep only one symbol definition.
> 
> Signed-off-by: Clement Leger <cleger@kalray.eu>
> ---
>  arch/kvx/cpu/barebox.lds.S | 9 ---------
>  1 file changed, 9 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/kvx/cpu/barebox.lds.S b/arch/kvx/cpu/barebox.lds.S
> index bf92564cf..77ebaf0ae 100644
> --- a/arch/kvx/cpu/barebox.lds.S
> +++ b/arch/kvx/cpu/barebox.lds.S
> @@ -10,8 +10,6 @@
>  OUTPUT_FORMAT("elf64-kvx")
>  OUTPUT_ARCH("kvx:kv3-1:64")
>  
> -#define DTB_DEFAULT_SIZE	(24 * 1024)
> -
>  SECTIONS
>  {
>  	. = CONFIG_ARCH_TEXT_BASE;
> @@ -54,13 +52,6 @@ SECTIONS
>  		RO_DATA_SECTION
>  	}
>  
> -	.dtb ALIGN(16):
> -	{
> -		__dtb_start = .;
> -		. += DTB_DEFAULT_SIZE;
> -		__dtb_end = .;
> -	}
> -
>  	_etext = .; /* End of text and rodata section */
>  
>  	.data ALIGN(4): {
> -- 
> 2.17.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-01  5:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 20:53 [PATCH] kvx: remove duplicated dtb symbols Clement Leger
2020-07-01  5:23 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox