From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 19/28] ARM: at91: add helpers for chain-loading barebox from SD-card
Date: Thu, 9 Jul 2020 16:19:31 +0200 [thread overview]
Message-ID: <20200709141931.GE15485@pengutronix.de> (raw)
In-Reply-To: <c9be71e8-1b06-7066-57e4-e86287b4e8f7@pengutronix.de>
On Mon, Jul 06, 2020 at 12:35:30AM +0200, Ahmad Fatoum wrote:
>
>
> On 7/5/20 8:42 PM, Sascha Hauer wrote:
> > On Wed, Jul 01, 2020 at 11:11:13AM +0200, Ahmad Fatoum wrote:
> >> +static void at91_fat_start_image(struct pbl_bio *bio,
> >> + void *buf, unsigned int len,
> >> + u32 r4)
> >> +{
> >> + void __noreturn (*bb)(void);
> >> + int ret;
> >> +
> >> + ret = pbl_fat_load(bio, "barebox.bin", buf, len);
> >> + if (ret < 0) {
> >> + pr_err("pbl_fat_load: error %d\n", ret);
> >> + return;
> >> + }
> >> +
> >> + bb = buf;
> >> +
> >> + sync_caches_for_execution();
> >> +
> >> + xload_bb(bb, r4);
> >> +}
> >> +
> >> +static const struct sdhci_instance {
> >> + void __iomem *base;
> >> + unsigned id;
> >> + u8 periph;
> >> + s8 pins[15];
> >> +} sdhci_instances[] = {
> >> + [0] = { SAMA5D2_BASE_SDHC0, SAMA5D2_ID_SDMMC0, AT91_MUX_PERIPH_A,
> >> + { 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 13, 10, 11, 12, -1 } },
> >> + [1] = { SAMA5D2_BASE_SDHC1, SAMA5D2_ID_SDMMC1, AT91_MUX_PERIPH_E,
> >> + { 18, 19, 20, 21, 22, 28, 30, -1 } },
> >> +};
> >
> > Can we use C99 initializer here please?
>
> Can do
>
> >
> >> +
> >> +/**
> >> + * sama5d2_sdhci_start_image - Load and start an image from FAT-formatted SDHCI
> >> + * @r4: value of r4 passed by BootROM
> >> + *
> >> + * Return: If successul, this function does not return. A negative error
> >
> > s/successul/successful/
> >
> >> + * code is returned when this function fails.
> >
> > This is not true, the function panics on error.
>
> It did when I first wrote the comment :D.
> Will reply with a fixup.
>
> >
> >> + */
> >> +void __noreturn sama5d2_sdhci_start_image(u32 r4)
> >> +{
> >> + void *buf = (void *)SAMA5_DDRCS;
> >> + const struct sdhci_instance *instance;
> >> + struct pbl_bio bio;
> >> + const s8 *pin;
> >> + int ret;
> >> +
> >> + instance = &sdhci_instances[!!sama5_bootsource_instance(r4)];
> >
> > Why "!!"? sama5_bootsource_instance() should return exactly 0 or 1 here.
>
> SAMA5_BOOTSOURCE_INSTANCE is GENMASK(7, 4). While it should only be 0 or 1
> on the sama5d2, better be on the safe side and force it to either 0 or 1.
"safe" would be to only accept 0 and 1 and refuse other values.
Interpreting everything != 0 as 1 is IMO not safe.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-09 14:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:10 [PATCH RESEND 00/28] ARM: at91: add sama5d2 first stage support Ahmad Fatoum
2020-07-01 9:10 ` [PATCH 01/28] ARM: at91: remove <mach/hardware.h> include from assembly code Ahmad Fatoum
2020-07-01 9:10 ` [PATCH 02/28] ARM: at91: sama5d2: cast peripheral base addresses to __iomem pointers Ahmad Fatoum
2020-07-01 9:10 ` [PATCH 03/28] ARM: at91: import at91bootstrap's at91_ddrsdrc.h Ahmad Fatoum
2020-07-01 9:10 ` [PATCH 04/28] ARM: at91: migrate at91sam9_ddrsdr.h to use " Ahmad Fatoum
2020-07-01 9:10 ` [PATCH 05/28] ARM: at91: replace at91sam9_ddrsdr.h with " Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 06/28] ARM: at91: import early_udelay from at91bootstrap Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 07/28] ARM: at91: import low level DDRAMC initialization code " Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 08/28] ARM: at91: watchdog: implement at91_wdt_disable Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 09/28] watchdog: add support for at91sam9/sama5 watchdog Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 10/28] ARM: at91: implement sama5d2 lowlevel init Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 11/28] ARM: at91: sama5d2: add sama5d2 matrix configuration Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 12/28] ARM: at91: add sama5d2 cache init Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 13/28] ARM: at91: add necessary Advanced Interrupt Controller configuration Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 14/28] ARM: at91: extend low level PMC driver for generic clk support Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 15/28] pbl: add block I/O API Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 16/28] fs: fat: extend for in-PBL support Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 17/28] mci: sdhci: atmel: extend driver for PBL usage Ahmad Fatoum
2020-07-05 18:52 ` Sascha Hauer
2020-07-05 22:32 ` Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 18/28] ARM: at91: add code for sama5 boot source detection Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 19/28] ARM: at91: add helpers for chain-loading barebox from SD-card Ahmad Fatoum
2020-07-05 18:42 ` Sascha Hauer
2020-07-05 22:35 ` Ahmad Fatoum
2020-07-06 6:26 ` [PATCH] fixup! " Ahmad Fatoum
2020-07-09 14:19 ` Sascha Hauer [this message]
2020-07-09 15:01 ` [PATCH v2] " Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 20/28] ARM: at91: sama5d2: reuse stack set-up by first stage Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 21/28] ARM: at91: debug_ll: remove duplicated IS_ENABLED(CONFIG_DEBUG_LL) condition Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 22/28] ARM: at91: sama5d2: reduce UART setup boilerplate with new helpers Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 23/28] ARM: at91: sama5d27-som1: add additional first stage entry point Ahmad Fatoum
2020-07-05 18:46 ` Sascha Hauer
2020-07-06 6:22 ` [PATCH] fixup! " Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 24/28] ARM: at91: sama5d2: read back memory size from DDRAM controller Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 25/28] ARM: at91: sama5d2: populate $bootsource and $bootsource_instance Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 26/28] ARM: at91: sama5d27-som1-ek: add barebox_update and multi environment support Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 27/28] ARM: at91: sama5d27-giantboard: add additional first stage entry point Ahmad Fatoum
2020-07-06 6:22 ` [PATCH] fixup! " Ahmad Fatoum
2020-07-01 9:11 ` [PATCH 28/28] ARM: at91: sama5d27-giantboard: add default environment/bbu Ahmad Fatoum
2020-07-11 5:13 ` [PATCH RESEND 00/28] ARM: at91: add sama5d2 first stage support Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2020-07-01 5:23 [PATCH " Ahmad Fatoum
2020-07-01 5:23 ` [PATCH 19/28] ARM: at91: add helpers for chain-loading barebox from SD-card Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709141931.GE15485@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox