mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Trent Piepho <trent.piepho@synapse.com>
To: barebox@lists.infradead.org
Cc: Trent Piepho <trent.piepho@synapse.com>
Subject: [PATCH 1/4] aiodev: Name channels with device instance name
Date: Wed,  9 Sep 2020 12:36:47 -0700	[thread overview]
Message-ID: <20200909193650.347646-1-trent.piepho@synapse.com> (raw)

When dynamically assigning device names, an aiodev's name will be
"aiodev" and an index, not part of the name string itself, will be
allocated dynamically.  These are combined to register a device with a
name like "aiodev0" or "aiodev1".

The shell environment variables use the device name, so one might use
"${aiodev0.in_value0_mV}" and "${aiodev1.in_value0_mV}".

However, the channel names that are used with aiochannel_get_by_name()
just use the aiodev's name and channel name.  So channel 0 of the 1st
aiodev would be "aiodev.in_value0_mV" and the 2nd aiodev would use the
same name.

Change the channel naming to use the device instance name, e.g.
"aiodev0", rather than the aiodev's base name.  This makes the names
used aiochannel_get_by_name() match the environment variable names and
also avoids duplicate names with more than one dynamically allocated
aiodev.

Signed-off-by: Trent Piepho <trent.piepho@synapse.com>
---
 drivers/aiodev/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/aiodev/core.c b/drivers/aiodev/core.c
index b8428346a..7d9170d2d 100644
--- a/drivers/aiodev/core.c
+++ b/drivers/aiodev/core.c
@@ -131,7 +131,7 @@ int aiodevice_register(struct aiodevice *aiodev)
 				  aiochannel_param_get_value,
 				  &aiochan->value, "%d", aiochan);
 
-		aiochan->name = xasprintf("%s.%s", aiodev->name, name);
+		aiochan->name = xasprintf("%s.%s", dev_name(&aiodev->dev), name);
 
 		free(name);
 	}
-- 
2.25.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2020-09-09 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 19:36 Trent Piepho [this message]
2020-09-09 19:36 ` [PATCH 2/4] aiodev: am335x_adc: Driver for ADC on TI AM335x SoCs Trent Piepho
2020-09-09 19:36 ` [PATCH 3/4] ARM: am335x: Enable TSC/ADC clock Trent Piepho
2020-09-09 19:36 ` [PATCH 4/4] ARM: beaglebone: Enable ADC Trent Piepho
2020-09-10  8:44 ` [PATCH 1/4] aiodev: Name channels with device instance name Ahmad Fatoum
2020-09-11 17:50   ` Trent Piepho
2020-09-14 10:45     ` Ahmad Fatoum
2020-09-15 12:58 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909193650.347646-1-trent.piepho@synapse.com \
    --to=trent.piepho@synapse.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox