From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Trent Piepho <trent.piepho@synapse.com>,
"barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/4] aiodev: Name channels with device instance name
Date: Mon, 14 Sep 2020 12:45:36 +0200 [thread overview]
Message-ID: <e841cf67-a3e3-d897-eda0-0cc48617912f@pengutronix.de> (raw)
In-Reply-To: <MW3PR18MB348474DA5350DA9BC3B4A9BA8A240@MW3PR18MB3484.namprd18.prod.outlook.com>
Hello Trent,
On 9/11/20 7:50 PM, Trent Piepho wrote:
>>> On 9/9/20 9:36 PM, Trent Piepho wrote:
>>> Change the channel naming to use the device instance name, e.g.
>>> "aiodev0", rather than the aiodev's base name. This makes the names
>>> used aiochannel_get_by_name() match the environment variable names and
>>> also avoids duplicate names with more than one dynamically allocated
>>> aiodev.
>>
>> sounds good, but that would silently break existing users, wouldn't i?
>> There are none in-tree, but I assume there are some in external patch
>> stacks, otherwise the function would've not been added.
>>
>> These patch stacks would rebase cleanly and build successfully, but
>> still be runtime broken. Would it makes sense to rename
>> aiochannel_get_by_name() because the API changed?
>
> Assuming they used dynamic names for the devices. So probably.
>
> I can rename it to aiochannel_by_name(). There are number of other
> functions in barebox that follow that pattern.
Ack.
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-14 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 19:36 Trent Piepho
2020-09-09 19:36 ` [PATCH 2/4] aiodev: am335x_adc: Driver for ADC on TI AM335x SoCs Trent Piepho
2020-09-09 19:36 ` [PATCH 3/4] ARM: am335x: Enable TSC/ADC clock Trent Piepho
2020-09-09 19:36 ` [PATCH 4/4] ARM: beaglebone: Enable ADC Trent Piepho
2020-09-10 8:44 ` [PATCH 1/4] aiodev: Name channels with device instance name Ahmad Fatoum
2020-09-11 17:50 ` Trent Piepho
2020-09-14 10:45 ` Ahmad Fatoum [this message]
2020-09-15 12:58 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e841cf67-a3e3-d897-eda0-0cc48617912f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=trent.piepho@synapse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox