mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: imx6: demote warning about ldb_di_clk reparenting
Date: Mon, 23 Nov 2020 17:39:51 +0100	[thread overview]
Message-ID: <20201123163951.GH24489@pengutronix.de> (raw)
In-Reply-To: <20201116194703.28238-1-a.fatoum@pengutronix.de>

On Mon, Nov 16, 2020 at 08:47:03PM +0100, Ahmad Fatoum wrote:
> Linux logging this is justified, because it alerts to problems in the
> boot firmware. barebox warning about it serves no real purpose other
> than indicating that barebox was chainloaded. Make it a debug log
> to not clutter the log.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/clk/imx/clk-imx6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/clk/imx/clk-imx6.c b/drivers/clk/imx/clk-imx6.c
> index cb030244581a..6935a8e85292 100644
> --- a/drivers/clk/imx/clk-imx6.c
> +++ b/drivers/clk/imx/clk-imx6.c
> @@ -482,9 +482,9 @@ static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
>  	of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
>  
>  	for (i = 0; i < 2; i++) {
> -		/* Warn if a glitch might have been introduced already */
> +		/* log if a glitch might have been introduced already */
>  		if (sel[i][0] != LDB_DI_SEL_MMDC_CH1_AXI) {
> -			pr_warn("ccm: ldb_di%d_sel already changed from reset value: %d\n",
> +			pr_debug("ccm: ldb_di%d_sel already changed from reset value: %d\n",
>  				i, sel[i][0]);
>  		}
>  
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-11-23 16:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 19:47 Ahmad Fatoum
2020-11-23 16:39 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123163951.GH24489@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox