mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] clk: imx6: demote warning about ldb_di_clk reparenting
@ 2020-11-16 19:47 Ahmad Fatoum
  2020-11-23 16:39 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-11-16 19:47 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Linux logging this is justified, because it alerts to problems in the
boot firmware. barebox warning about it serves no real purpose other
than indicating that barebox was chainloaded. Make it a debug log
to not clutter the log.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/clk/imx/clk-imx6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx6.c b/drivers/clk/imx/clk-imx6.c
index cb030244581a..6935a8e85292 100644
--- a/drivers/clk/imx/clk-imx6.c
+++ b/drivers/clk/imx/clk-imx6.c
@@ -482,9 +482,9 @@ static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
 	of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
 
 	for (i = 0; i < 2; i++) {
-		/* Warn if a glitch might have been introduced already */
+		/* log if a glitch might have been introduced already */
 		if (sel[i][0] != LDB_DI_SEL_MMDC_CH1_AXI) {
-			pr_warn("ccm: ldb_di%d_sel already changed from reset value: %d\n",
+			pr_debug("ccm: ldb_di%d_sel already changed from reset value: %d\n",
 				i, sel[i][0]);
 		}
 
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: imx6: demote warning about ldb_di_clk reparenting
  2020-11-16 19:47 [PATCH] clk: imx6: demote warning about ldb_di_clk reparenting Ahmad Fatoum
@ 2020-11-23 16:39 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-11-23 16:39 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Nov 16, 2020 at 08:47:03PM +0100, Ahmad Fatoum wrote:
> Linux logging this is justified, because it alerts to problems in the
> boot firmware. barebox warning about it serves no real purpose other
> than indicating that barebox was chainloaded. Make it a debug log
> to not clutter the log.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/clk/imx/clk-imx6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/clk/imx/clk-imx6.c b/drivers/clk/imx/clk-imx6.c
> index cb030244581a..6935a8e85292 100644
> --- a/drivers/clk/imx/clk-imx6.c
> +++ b/drivers/clk/imx/clk-imx6.c
> @@ -482,9 +482,9 @@ static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
>  	of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
>  
>  	for (i = 0; i < 2; i++) {
> -		/* Warn if a glitch might have been introduced already */
> +		/* log if a glitch might have been introduced already */
>  		if (sel[i][0] != LDB_DI_SEL_MMDC_CH1_AXI) {
> -			pr_warn("ccm: ldb_di%d_sel already changed from reset value: %d\n",
> +			pr_debug("ccm: ldb_di%d_sel already changed from reset value: %d\n",
>  				i, sel[i][0]);
>  		}
>  
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-23 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 19:47 [PATCH] clk: imx6: demote warning about ldb_di_clk reparenting Ahmad Fatoum
2020-11-23 16:39 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox