mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] LICENSES: exceptions: factor out eCos-exception-2.0 for GPL
Date: Tue, 24 Nov 2020 09:44:34 +0100	[thread overview]
Message-ID: <20201124084434.GC14718@pengutronix.de> (raw)
In-Reply-To: <20201123160128.15947-2-a.fatoum@pengutronix.de>

On Mon, Nov 23, 2020 at 05:01:27PM +0100, Ahmad Fatoum wrote:
> We have code imported from eCos that's licensed with this exception.
> Replace instances of the exceptions with a SPDX-License-Identifier
> referencing the exception in our LICENSES directory.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  LICENSES/exceptions/eCos-exception-2.0 | 13 +++++++++++++
>  common/dummy_malloc.c                  | 21 +--------------------
>  drivers/mtd/nand/nand_ecc.c            | 22 +---------------------
>  drivers/serial/arm_dcc.c               | 21 +--------------------
>  4 files changed, 16 insertions(+), 61 deletions(-)
>  create mode 100644 LICENSES/exceptions/eCos-exception-2.0
> 
> diff --git a/LICENSES/exceptions/eCos-exception-2.0 b/LICENSES/exceptions/eCos-exception-2.0
> new file mode 100644
> index 000000000000..291103666f10
> --- /dev/null
> +++ b/LICENSES/exceptions/eCos-exception-2.0
> @@ -0,0 +1,13 @@
> +SPDX-Exception-Identifier: eCos-exception-2.0
> +SPDX-URL: https://spdx.org/licenses/eCos-exception-2.0.html
> +SPDX-Licenses: GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-2.0+
> +License-Text:
> +  As a special exception, if other files instantiate templates or use macros or
> +  inline functions from this file, or you compile this file and link it with
> +  other works to produce a work based on this file, this file does not by itself
> +  cause the resulting work to be covered by the GNU General Public License.
> +  However the source code for this file must still be made available in
> +  accordance with section (3) of the GNU General Public License.
> +
> +  This exception does not invalidate any other reasons why a work based on this
> +  file might be covered by the GNU General Public License.
> diff --git a/common/dummy_malloc.c b/common/dummy_malloc.c
> index 0120d9be2e85..ed74bd2f2302 100644
> --- a/common/dummy_malloc.c
> +++ b/common/dummy_malloc.c
> @@ -1,25 +1,6 @@
> +/* SPDX-License-Identifier: GPL-2.0-only WITH eCos-exception-2.0 */
>  /*
>   * Copyright (C) 2013 Sascha Hauer <s.hauer@pengutronix.de>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - *
> - * As a special exception, if other files instantiate templates or use macros
> - * or inline functions from this file, or you compile this file and link it
> - * with other works to produce a work based on this file, this file does not
> - * by itself cause the resulting work to be covered by the GNU General Public
> - * License. However the source code for this file must still be made available
> - * in accordance with section (3) of the GNU General Public License.
> -
> - * This exception does not invalidate any other reasons why a work based on
> - * this file might be covered by the GNU General Public License.
>   */

This looks like I accidently copied the wrong header. I don't think I
did this on purpose. It doesn't make much sense to me when compiling
against dummy malloc is different than compiling against tlsf malloc or
dlmalloc.

>  #include <common.h>
>  #include <malloc.h>
> diff --git a/drivers/mtd/nand/nand_ecc.c b/drivers/mtd/nand/nand_ecc.c
> index fd6ad7edc8e5..741282093df9 100644
> --- a/drivers/mtd/nand/nand_ecc.c
> +++ b/drivers/mtd/nand/nand_ecc.c

I'll drop this hunk, it's gone with the recent NAND layer update.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-11-24  8:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 16:01 [PATCH 1/3] ARM: at91: sama5d2: giantboard: fix typo in SPDX-License-Identifier Ahmad Fatoum
2020-11-23 16:01 ` [PATCH 2/3] LICENSES: exceptions: factor out eCos-exception-2.0 for GPL Ahmad Fatoum
2020-11-24  8:44   ` Sascha Hauer [this message]
2020-11-24  9:22     ` Ahmad Fatoum
2020-11-26 14:48   ` Roland Hieber
2020-11-23 16:01 ` [PATCH 3/3] common: replace license statements with SPDX-License-Identifiers Ahmad Fatoum
2020-11-25  7:33   ` Uwe Kleine-König
2020-11-26 14:58   ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124084434.GC14718@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox