Re: [PATCH 3/3] common: replace license statements with SPDX-License-Identifiers

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2705 bytes --]

Hello Ahmad,

On Mon, Nov 23, 2020 at 05:01:28PM +0100, Ahmad Fatoum wrote:
> For all files in common/ that already have a license text:
>   - Replace with appropriate SPDX-License-Identifier
>   - Remove empty comment lines around replacement
>   - remove comment completely if only thing remaining is name
>     of file without description

Great you continue to drive this forward!

> diff --git a/common/bbu.c b/common/bbu.c
> index f284c341b91b..1279d5615525 100644
> --- a/common/bbu.c
> +++ b/common/bbu.c
> @@ -1,16 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>  /*
>   * bbu.c - barebox update functions
>   *

I usually add an empty line after the SPDX stuff, but I admit this is
subjective and in the long run probably nothing we can get for each
source file.

> diff --git a/common/env.c b/common/env.c
> index fbaaac4f2f5c..d5fc98436263 100644
> --- a/common/env.c
> +++ b/common/env.c
> @@ -1,17 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-o

"nly" is missing

>  /*
>   * env.c - environment variables storage
>   *
>   * Copyright (c) 2007 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
>   */
>  
>  /**
> diff --git a/common/environment.c b/common/environment.c
> index 6e58f122bad2..038a480e5f92 100644
> --- a/common/environment.c
> +++ b/common/environment.c
> @@ -1,15 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0-o

ditto.

>  /*
>   * Copyright (c) 2007 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
>   */
>  
>  /**

Other than that the changes look fine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox