mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2 1/2] usb: host: ehci: fix mismatch in format string
@ 2020-12-03 10:42 Ahmad Fatoum
  2020-12-03 10:42 ` [PATCH v2 2/2] commands: memtester: fix mismatched " Ahmad Fatoum
  2020-12-03 11:17 ` [PATCH v2 1/2] usb: host: ehci: fix mismatch in " Uwe Kleine-König
  0 siblings, 2 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2020-12-03 10:42 UTC (permalink / raw)
  To: barebox; +Cc: ukl, Ahmad Fatoum

sz is of type size_t. Use the appropriate format string specifier for
printing it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Cc: ukl@pengutronix.de
v1 -> v2: fix broken English in commit message (Uwe)
---
 drivers/usb/host/ehci-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 38999927c5a8..287849102d68 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -240,7 +240,7 @@ static int ehci_td_buffer(struct qTD *td, dma_addr_t addr, size_t sz)
 	}
 
 	if (idx == buffer_count) {
-		pr_debug("out of buffer pointers (%u bytes left)\n", sz);
+		pr_debug("out of buffer pointers (%zu bytes left)\n", sz);
 		return -ENOMEM;
 	}
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] commands: memtester: fix mismatched format string
  2020-12-03 10:42 [PATCH v2 1/2] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
@ 2020-12-03 10:42 ` Ahmad Fatoum
  2020-12-07  7:21   ` Sascha Hauer
  2020-12-03 11:17 ` [PATCH v2 1/2] usb: host: ehci: fix mismatch in " Uwe Kleine-König
  1 sibling, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2020-12-03 10:42 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

expression is of type size_t. Use the appropriate format string specifier
for printing it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2: new patch
---
 commands/memtester/memtester.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/memtester/memtester.c b/commands/memtester/memtester.c
index 8b64d3232958..130dc97c8334 100644
--- a/commands/memtester/memtester.c
+++ b/commands/memtester/memtester.c
@@ -139,7 +139,7 @@ static int do_memtester(int argc, char **argv) {
 
     wantbytes = (size_t) strtoull_suffix(argv[optind], 0, 0);
     if (wantbytes < 2 * sizeof(ul)) {
-        printf("need at least %ldB of memory to test\n", 2 * sizeof(ul));
+        printf("need at least %zuB of memory to test\n", 2 * sizeof(ul));
         return COMMAND_ERROR_USAGE;
     }
     wantmb = (wantbytes >> 20);
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] usb: host: ehci: fix mismatch in format string
  2020-12-03 10:42 [PATCH v2 1/2] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
  2020-12-03 10:42 ` [PATCH v2 2/2] commands: memtester: fix mismatched " Ahmad Fatoum
@ 2020-12-03 11:17 ` Uwe Kleine-König
  1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-12-03 11:17 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox


[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]

On Thu, Dec 03, 2020 at 11:42:56AM +0100, Ahmad Fatoum wrote:
> sz is of type size_t. Use the appropriate format string specifier for
> printing it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] commands: memtester: fix mismatched format string
  2020-12-03 10:42 ` [PATCH v2 2/2] commands: memtester: fix mismatched " Ahmad Fatoum
@ 2020-12-07  7:21   ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2020-12-07  7:21 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Thu, Dec 03, 2020 at 11:42:57AM +0100, Ahmad Fatoum wrote:
> expression is of type size_t. Use the appropriate format string specifier
> for printing it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2: new patch
> ---
>  commands/memtester/memtester.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/commands/memtester/memtester.c b/commands/memtester/memtester.c
> index 8b64d3232958..130dc97c8334 100644
> --- a/commands/memtester/memtester.c
> +++ b/commands/memtester/memtester.c
> @@ -139,7 +139,7 @@ static int do_memtester(int argc, char **argv) {
>  
>      wantbytes = (size_t) strtoull_suffix(argv[optind], 0, 0);
>      if (wantbytes < 2 * sizeof(ul)) {
> -        printf("need at least %ldB of memory to test\n", 2 * sizeof(ul));
> +        printf("need at least %zuB of memory to test\n", 2 * sizeof(ul));
>          return COMMAND_ERROR_USAGE;
>      }
>      wantmb = (wantbytes >> 20);
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-07  7:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 10:42 [PATCH v2 1/2] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
2020-12-03 10:42 ` [PATCH v2 2/2] commands: memtester: fix mismatched " Ahmad Fatoum
2020-12-07  7:21   ` Sascha Hauer
2020-12-03 11:17 ` [PATCH v2 1/2] usb: host: ehci: fix mismatch in " Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox