[PATCH] video: sdl: delete useless debug output

[PATCH] video: sdl: delete useless debug output

[Ahmad Fatoum]

The information on the color mode is only populated at framebuffer
enable time. At probe time, it's all zero, so it's useless to print it
out. Drop it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/video/sdl.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/video/sdl.c b/drivers/video/sdl.c
index 8f5b409efb4a..9811b2cf128e 100644
--- a/drivers/video/sdl.c
+++ b/drivers/video/sdl.c
@@ -59,15 +59,6 @@ static int sdlfb_probe(struct device_d *dev)
 	fb->screen_base = xzalloc(fb->xres * fb->yres *
 				  fb->bits_per_pixel >> 3);
 
-	dev_dbg(dev, "red: length = %d, offset = %d\n",
-		fb->red.length, fb->red.offset);
-	dev_dbg(dev, "green: length = %d, offset = %d\n",
-		fb->green.length, fb->green.offset);
-	dev_dbg(dev, "blue: length = %d, offset = %d\n",
-		fb->blue.length, fb->blue.offset);
-	dev_dbg(dev, "transp: length = %d, offset = %d\n",
-		fb->transp.length, fb->transp.offset);
-
 	/* add runtime hardware info */
 	dev->priv = fb;
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] video: sdl: delete useless debug output

[Sascha Hauer]

On Tue, Dec 29, 2020 at 01:34:33PM +0100, Ahmad Fatoum wrote:
> The information on the color mode is only populated at framebuffer
> enable time. At probe time, it's all zero, so it's useless to print it
> out. Drop it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/video/sdl.c | 9 ---------
>  1 file changed, 9 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/sdl.c b/drivers/video/sdl.c
> index 8f5b409efb4a..9811b2cf128e 100644
> --- a/drivers/video/sdl.c
> +++ b/drivers/video/sdl.c
> @@ -59,15 +59,6 @@ static int sdlfb_probe(struct device_d *dev)
>  	fb->screen_base = xzalloc(fb->xres * fb->yres *
>  				  fb->bits_per_pixel >> 3);
>  
> -	dev_dbg(dev, "red: length = %d, offset = %d\n",
> -		fb->red.length, fb->red.offset);
> -	dev_dbg(dev, "green: length = %d, offset = %d\n",
> -		fb->green.length, fb->green.offset);
> -	dev_dbg(dev, "blue: length = %d, offset = %d\n",
> -		fb->blue.length, fb->blue.offset);
> -	dev_dbg(dev, "transp: length = %d, offset = %d\n",
> -		fb->transp.length, fb->transp.offset);
> -
>  	/* add runtime hardware info */
>  	dev->priv = fb;
>  
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox