* [PATCH] fixup! of: overlay: do not parse phandles as properties
@ 2021-01-13 17:00 Rouven Czerwinski
2021-01-13 17:12 ` Marco Felsch
0 siblings, 1 reply; 3+ messages in thread
From: Rouven Czerwinski @ 2021-01-13 17:00 UTC (permalink / raw)
To: barebox; +Cc: Rouven Czerwinski
This breaks the eventual fixup of phandles into the linux device tree.
Fix this by also keeping the phandle properties in the DT.
---
drivers/of/overlay.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 0bebe26e39..d7695726fc 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -60,7 +60,6 @@ static int of_overlay_apply(struct device_node *target,
if (of_prop_cmp(prop->name, "phandle") == 0) {
target->phandle = be32_to_cpup(prop->value);
- continue;
}
err = of_set_property(target, prop->name, prop->value,
--
2.29.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fixup! of: overlay: do not parse phandles as properties
2021-01-13 17:00 [PATCH] fixup! of: overlay: do not parse phandles as properties Rouven Czerwinski
@ 2021-01-13 17:12 ` Marco Felsch
2021-01-18 8:02 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Marco Felsch @ 2021-01-13 17:12 UTC (permalink / raw)
To: Rouven Czerwinski; +Cc: barebox
On 21-01-13 18:00, Rouven Czerwinski wrote:
> This breaks the eventual fixup of phandles into the linux device tree.
> Fix this by also keeping the phandle properties in the DT.
> ---
> drivers/of/overlay.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index 0bebe26e39..d7695726fc 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -60,7 +60,6 @@ static int of_overlay_apply(struct device_node *target,
>
> if (of_prop_cmp(prop->name, "phandle") == 0) {
> target->phandle = be32_to_cpup(prop->value);
> - continue;
> }
Nit:
We could also remove the {} so it's becoming a two-liner :)
Regards,
Marco
>
> err = of_set_property(target, prop->name, prop->value,
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fixup! of: overlay: do not parse phandles as properties
2021-01-13 17:12 ` Marco Felsch
@ 2021-01-18 8:02 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2021-01-18 8:02 UTC (permalink / raw)
To: Marco Felsch; +Cc: barebox, Rouven Czerwinski
On Wed, Jan 13, 2021 at 06:12:58PM +0100, Marco Felsch wrote:
> On 21-01-13 18:00, Rouven Czerwinski wrote:
> > This breaks the eventual fixup of phandles into the linux device tree.
> > Fix this by also keeping the phandle properties in the DT.
> > ---
> > drivers/of/overlay.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> > index 0bebe26e39..d7695726fc 100644
> > --- a/drivers/of/overlay.c
> > +++ b/drivers/of/overlay.c
> > @@ -60,7 +60,6 @@ static int of_overlay_apply(struct device_node *target,
> >
> > if (of_prop_cmp(prop->name, "phandle") == 0) {
> > target->phandle = be32_to_cpup(prop->value);
> > - continue;
> > }
>
> Nit:
>
> We could also remove the {} so it's becoming a two-liner :)
Did that while applying
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 17:00 [PATCH] fixup! of: overlay: do not parse phandles as properties Rouven Czerwinski
2021-01-13 17:12 ` Marco Felsch
2021-01-18 8:02 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox