From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] efi: declare prototype for close_protocol BootService
Date: Mon, 1 Feb 2021 09:43:50 +0100 [thread overview]
Message-ID: <20210201084350.GK19583@pengutronix.de> (raw)
In-Reply-To: <20210129135833.5748-1-a.fatoum@pengutronix.de>
On Fri, Jan 29, 2021 at 02:58:33PM +0100, Ahmad Fatoum wrote:
> Sometimes, drivers need to probe whether the EFI device in front of them
> is the actual hardware they expect. If it's not, the driver should call
> close_protocol to leave the decision on whether to match this device to
> another driver. Use the correct type for close_protocol to facilitate
> this.
>
> No functional change, as no in-tree driver makes use of this yet.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> include/efi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/include/efi.h b/include/efi.h
> index 43c05939513d..f6833fde1e75 100644
> --- a/include/efi.h
> +++ b/include/efi.h
> @@ -256,7 +256,8 @@ typedef struct {
> efi_status_t (EFIAPI *open_protocol)(efi_handle_t handle, efi_guid_t *protocol,
> void ** interface, efi_handle_t agent_handle,
> efi_handle_t controller_handle, u32 attributes);
> - void *close_protocol;
> + efi_status_t (EFIAPI *close_protocol)(efi_handle_t handle, efi_guid_t *protocol,
> + efi_handle_t agent, efi_handle_t controller);
> efi_status_t(EFIAPI *open_protocol_information)(efi_handle_t handle, efi_guid_t *Protocol,
> struct efi_open_protocol_information_entry **entry_buffer,
> unsigned long *entry_count);
> --
> 2.30.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-02-01 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 13:58 Ahmad Fatoum
2021-02-01 8:43 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201084350.GK19583@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox