mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] video: bochs: pci: fix unterminated PCI device table
@ 2021-04-10 10:48 Ahmad Fatoum
  2021-04-13  7:18 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2021-04-10 10:48 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Like other device id tables across tree, the last element is expected to
be zeroed to act as sentinel. Fix the omission.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/video/bochs/bochs_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/bochs/bochs_pci.c b/drivers/video/bochs/bochs_pci.c
index 28785e1c0667..39c4d1b662ab 100644
--- a/drivers/video/bochs/bochs_pci.c
+++ b/drivers/video/bochs/bochs_pci.c
@@ -27,6 +27,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
 static DEFINE_PCI_DEVICE_TABLE(bochs_pci_tbl) = {
 	/* https://github.com/qemu/qemu/blob/master/docs/specs/standard-vga.txt */
 	{ PCI_DEVICE(0x1234, 0x1111) },
+	{ },
 };
 
 static struct pci_driver bochs_pci_driver = {
-- 
2.30.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] video: bochs: pci: fix unterminated PCI device table
  2021-04-10 10:48 [PATCH master] video: bochs: pci: fix unterminated PCI device table Ahmad Fatoum
@ 2021-04-13  7:18 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-04-13  7:18 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Sat, Apr 10, 2021 at 12:48:07PM +0200, Ahmad Fatoum wrote:
> Like other device id tables across tree, the last element is expected to
> be zeroed to act as sentinel. Fix the omission.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/video/bochs/bochs_pci.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/bochs/bochs_pci.c b/drivers/video/bochs/bochs_pci.c
> index 28785e1c0667..39c4d1b662ab 100644
> --- a/drivers/video/bochs/bochs_pci.c
> +++ b/drivers/video/bochs/bochs_pci.c
> @@ -27,6 +27,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
>  static DEFINE_PCI_DEVICE_TABLE(bochs_pci_tbl) = {
>  	/* https://github.com/qemu/qemu/blob/master/docs/specs/standard-vga.txt */
>  	{ PCI_DEVICE(0x1234, 0x1111) },
> +	{ },
>  };
>  
>  static struct pci_driver bochs_pci_driver = {
> -- 
> 2.30.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-13  7:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10 10:48 [PATCH master] video: bochs: pci: fix unterminated PCI device table Ahmad Fatoum
2021-04-13  7:18 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox