From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX7/8M: reliably detect serial boot
Date: Tue, 13 Apr 2021 09:39:16 +0200 [thread overview]
Message-ID: <20210413073916.GI19819@pengutronix.de> (raw)
In-Reply-To: <20210412222416.25723-1-a.fatoum@pengutronix.de>
On Tue, Apr 13, 2021 at 12:24:16AM +0200, Ahmad Fatoum wrote:
> While not documented in the reference manual,
> info->boot_device_type was observed to equal 15 when:
>
> - SoC is strapped for serial boot
> - SoC falls back into serial boot after failed strapped primary
>
> The latter went so far undetected. Fix this.
> What's not tested is:
>
> - SoC falls back into serial boot after failed primary from fuses
> - SoC warm resets directly into serial boot because of BMODE
>
> If those works, we could drop the imx6_bootsource_serial check at the
> beginning, but for now, just leave it be.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/arm/mach-imx/boot.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-imx/boot.c b/arch/arm/mach-imx/boot.c
> index c3cf4b85ff25..e9b5a4944390 100644
> --- a/arch/arm/mach-imx/boot.c
> +++ b/arch/arm/mach-imx/boot.c
> @@ -506,6 +506,9 @@ static void __imx7_get_boot_source(enum bootsource *src, int *instance,
> case 5:
> *src = BOOTSOURCE_NOR;
> break;
> + case 15:
> + *src = BOOTSOURCE_SERIAL;
> + break;
> default:
> break;
> }
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-04-13 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 22:24 Ahmad Fatoum
2021-04-13 7:39 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413073916.GI19819@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox