mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX: demote reset reason print to debug level
Date: Mon, 3 May 2021 13:18:29 +0200	[thread overview]
Message-ID: <20210503111829.GA19819@pengutronix.de> (raw)
In-Reply-To: <20210422110849.1556472-1-l.stach@pengutronix.de>

On Thu, Apr 22, 2021 at 01:08:49PM +0200, Lucas Stach wrote:
> The i.MX reset reason is not really helpful on its own, as it needs
> to be augmented with other information like the watchdog state to get
> the real system reset reason. As it stands this log is more confusing
> than answering any questions a user might have.
> 
> Demote the log to debug level to stop this confusion.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/mach-imx/imx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-imx/imx.c b/arch/arm/mach-imx/imx.c
> index 3d8c55c54ecd..bd7e9ac42320 100644
> --- a/arch/arm/mach-imx/imx.c
> +++ b/arch/arm/mach-imx/imx.c
> @@ -209,6 +209,6 @@ void imx_set_reset_reason(void __iomem *srsr,
>  
>  	reset_source_set_prinst(type, RESET_SOURCE_DEFAULT_PRIORITY, instance);
>  
> -	pr_info("i.MX reset reason %s (SRSR: 0x%08x)\n",
> -		reset_source_to_string(type), reg);
> +	pr_debug("i.MX reset reason %s (SRSR: 0x%08x)\n",
> +		 reset_source_to_string(type), reg);
>  }
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-05-03 11:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 11:08 Lucas Stach
2021-04-22 21:43 ` Marco Felsch
2021-05-03 11:18 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503111829.GA19819@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    --subject='Re: [PATCH] ARM: i.MX: demote reset reason print to debug level' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox