mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX: demote reset reason print to debug level
@ 2021-04-22 11:08 Lucas Stach
  2021-04-22 21:43 ` Marco Felsch
  2021-05-03 11:18 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Lucas Stach @ 2021-04-22 11:08 UTC (permalink / raw)
  To: barebox

The i.MX reset reason is not really helpful on its own, as it needs
to be augmented with other information like the watchdog state to get
the real system reset reason. As it stands this log is more confusing
than answering any questions a user might have.

Demote the log to debug level to stop this confusion.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-imx/imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/imx.c b/arch/arm/mach-imx/imx.c
index 3d8c55c54ecd..bd7e9ac42320 100644
--- a/arch/arm/mach-imx/imx.c
+++ b/arch/arm/mach-imx/imx.c
@@ -209,6 +209,6 @@ void imx_set_reset_reason(void __iomem *srsr,
 
 	reset_source_set_prinst(type, RESET_SOURCE_DEFAULT_PRIORITY, instance);
 
-	pr_info("i.MX reset reason %s (SRSR: 0x%08x)\n",
-		reset_source_to_string(type), reg);
+	pr_debug("i.MX reset reason %s (SRSR: 0x%08x)\n",
+		 reset_source_to_string(type), reg);
 }
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: i.MX: demote reset reason print to debug level
  2021-04-22 11:08 [PATCH] ARM: i.MX: demote reset reason print to debug level Lucas Stach
@ 2021-04-22 21:43 ` Marco Felsch
  2021-05-03 11:18 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2021-04-22 21:43 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On 21-04-22 13:08, Lucas Stach wrote:
> The i.MX reset reason is not really helpful on its own, as it needs
> to be augmented with other information like the watchdog state to get
> the real system reset reason. As it stands this log is more confusing
> than answering any questions a user might have.
> 
> Demote the log to debug level to stop this confusion.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: i.MX: demote reset reason print to debug level
  2021-04-22 11:08 [PATCH] ARM: i.MX: demote reset reason print to debug level Lucas Stach
  2021-04-22 21:43 ` Marco Felsch
@ 2021-05-03 11:18 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2021-05-03 11:18 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Thu, Apr 22, 2021 at 01:08:49PM +0200, Lucas Stach wrote:
> The i.MX reset reason is not really helpful on its own, as it needs
> to be augmented with other information like the watchdog state to get
> the real system reset reason. As it stands this log is more confusing
> than answering any questions a user might have.
> 
> Demote the log to debug level to stop this confusion.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/mach-imx/imx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-imx/imx.c b/arch/arm/mach-imx/imx.c
> index 3d8c55c54ecd..bd7e9ac42320 100644
> --- a/arch/arm/mach-imx/imx.c
> +++ b/arch/arm/mach-imx/imx.c
> @@ -209,6 +209,6 @@ void imx_set_reset_reason(void __iomem *srsr,
>  
>  	reset_source_set_prinst(type, RESET_SOURCE_DEFAULT_PRIORITY, instance);
>  
> -	pr_info("i.MX reset reason %s (SRSR: 0x%08x)\n",
> -		reset_source_to_string(type), reg);
> +	pr_debug("i.MX reset reason %s (SRSR: 0x%08x)\n",
> +		 reset_source_to_string(type), reg);
>  }
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-03 11:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 11:08 [PATCH] ARM: i.MX: demote reset reason print to debug level Lucas Stach
2021-04-22 21:43 ` Marco Felsch
2021-05-03 11:18 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git