From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] fixup! common: add initial barebox deep-probe support
Date: Mon, 3 May 2021 13:54:59 +0200 [thread overview]
Message-ID: <20210503115459.GE19819@pengutronix.de> (raw)
In-Reply-To: <20210428102821.2287-1-m.felsch@pengutronix.de>
On Wed, Apr 28, 2021 at 12:28:19PM +0200, Marco Felsch wrote:
> ---
> Hi,
>
> this is just a proposal to change the current linker array approach to
> an initcall approach. Why? Because now we can simply register a
> board-driver without having to list each compatible.
>
> I used the pure_initcall without adding a new one, since the
> documentation says that pure_initcalls are used to init variables. In
> our case we init boards_list.
>
> Regards,
> Marco
>
>
> -extern struct deep_probe_entry __barebox_deep_probe_start;
> -extern struct deep_probe_entry __barebox_deep_probe_end;
> +#define deep_probe_enable_board_driver(drv) \
> + _deep_probe_enable_driver(__UNIQUE_ID(deepprobe),drv)
>
> -#define __BAREBOX_DEEP_PROBE_ENABLE(_entry,_compatible) \
> - static const struct deep_probe_entry _entry \
> - __attribute__ ((used,section (".barebox_deep_probe_" __stringify(_entry)))) = { \
> - .compatible = _compatible, \
> - }
> +#define _deep_probe_enable_compatible(id,compatible) \
> + static int __init id(void) \
> + { \
> + return deep_probe_enable_board(NULL,compatible);\
> + } \
> + pure_initcall(id)
>
> -#define BAREBOX_DEEP_PROBE_ENABLE(_compatible) \
> - __BAREBOX_DEEP_PROBE_ENABLE(__UNIQUE_ID(deepprobe),_compatible)
I like the version with the linker array as we don't add a whole bunch
of new initcalls. Why not simply replace the _compatible argument with a
pointer to a of_device_id array?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-05-03 11:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:49 [PATCH v4 00/17] barebox deep probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 01/17] imx53: remove unused imx53_add_nand Sascha Hauer
2021-04-16 9:49 ` [PATCH 02/17] of: platform: remove check of already added devices Sascha Hauer
2021-04-16 9:49 ` [PATCH 03/17] of: platform: Keep track of populated platform devices Sascha Hauer
2021-04-16 9:49 ` [PATCH 04/17] of: base: move memory init from DT to initcall Sascha Hauer
2021-04-16 9:49 ` [PATCH 05/17] of: base: move clock init from of_probe() to barebox_register_of() Sascha Hauer
2021-04-16 9:49 ` [PATCH 06/17] of: Set of_chosen and of_model earlier Sascha Hauer
2021-04-16 9:49 ` [PATCH 07/17] of: implement of_get_stdoutpath() Sascha Hauer
2021-04-16 9:49 ` [PATCH 08/17] initcall: add of_populate_initcall Sascha Hauer
2021-04-16 9:49 ` [PATCH 09/17] common: add initial barebox deep-probe support Sascha Hauer
2021-04-19 7:16 ` Ahmad Fatoum
2021-04-26 8:15 ` Marco Felsch
2021-04-16 9:49 ` [PATCH 10/17] pinctrl: Find controller node first Sascha Hauer
2021-04-16 9:49 ` [PATCH 11/17] common: Explicitly probe consoles earlier with deep probe Sascha Hauer
2021-04-16 9:49 ` [PATCH 12/17] pinctrl: Add deep probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 13/17] ARM: i.MX: esdctl: add deep-probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 14/17] ARM: stm32mp: ddrctrl: " Sascha Hauer
2021-04-16 9:49 ` [PATCH 15/17] ARM: boards: mx6-sabrelite: " Sascha Hauer
2021-04-16 9:49 ` [PATCH 16/17] ARM: i.MX Phytec physom: convert to board driver Sascha Hauer
2021-04-16 9:49 ` [PATCH 17/17] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer
2021-04-19 7:12 ` Ahmad Fatoum
2021-04-26 9:20 ` Marco Felsch
2021-04-26 9:26 ` Marco Felsch
2021-04-26 9:36 ` Ahmad Fatoum
2021-04-26 10:03 ` Marco Felsch
2021-04-19 7:35 ` [PATCH v4 00/17] barebox deep probe support Ahmad Fatoum
2021-04-28 10:28 ` [PATCH 1/3] fixup! common: add initial barebox deep-probe support Marco Felsch
2021-04-28 10:28 ` [PATCH 2/3] fixup! ARM: boards: mx6-sabrelite: add " Marco Felsch
2021-04-28 10:28 ` [PATCH 3/3] fixup! ARM: i.MX Phytec physom: Add " Marco Felsch
2021-04-28 10:42 ` [PATCH 1/3] fixup! common: add initial barebox " Ahmad Fatoum
2021-04-28 10:48 ` Marco Felsch
2021-04-28 11:21 ` Marco Felsch
2021-05-03 11:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503115459.GE19819@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox