mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: [PATCH 05/17] of: base: move clock init from of_probe() to barebox_register_of()
Date: Fri, 16 Apr 2021 11:49:31 +0200	[thread overview]
Message-ID: <20210416094943.3648-6-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20210416094943.3648-1-s.hauer@pengutronix.de>

From: Marco Felsch <m.felsch@pengutronix.de>

This is required for the new deep-probe mechanism. Barebox deep-probe
calls of_probe() very late and so clock drivers using the old
CLK_OF_DECLARE_DRIVER() mechanism are added very late. This would break
the deep-probe approach.

Move of_clk_init() and call it right before of_probe() should have no
impact because of_clk_init() depends only on an unflatten dtb.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Link: https://lore.pengutronix.de/20201021115813.31645-6-m.felsch@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/of/base.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 549a0a2c2c..7b3cfa8393 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1707,8 +1707,10 @@ void barebox_register_of(struct device_node *root)
 	of_set_root_node(root);
 	of_fix_tree(root);
 
-	if (IS_ENABLED(CONFIG_OFDEVICE))
+	if (IS_ENABLED(CONFIG_OFDEVICE)) {
+		of_clk_init(root, NULL);
 		of_probe();
+	}
 }
 
 void barebox_register_fdt(const void *dtb)
@@ -2335,7 +2337,6 @@ int of_probe(void)
 
 	of_platform_device_create_root(root_node);
 
-	of_clk_init(root_node, NULL);
 	of_platform_populate(root_node, of_default_bus_match_table, NULL);
 
 	return 0;
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-04-16 10:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  9:49 [PATCH v4 00/17] barebox deep probe support Sascha Hauer
2021-04-16  9:49 ` [PATCH 01/17] imx53: remove unused imx53_add_nand Sascha Hauer
2021-04-16  9:49 ` [PATCH 02/17] of: platform: remove check of already added devices Sascha Hauer
2021-04-16  9:49 ` [PATCH 03/17] of: platform: Keep track of populated platform devices Sascha Hauer
2021-04-16  9:49 ` [PATCH 04/17] of: base: move memory init from DT to initcall Sascha Hauer
2021-04-16  9:49 ` Sascha Hauer [this message]
2021-04-16  9:49 ` [PATCH 06/17] of: Set of_chosen and of_model earlier Sascha Hauer
2021-04-16  9:49 ` [PATCH 07/17] of: implement of_get_stdoutpath() Sascha Hauer
2021-04-16  9:49 ` [PATCH 08/17] initcall: add of_populate_initcall Sascha Hauer
2021-04-16  9:49 ` [PATCH 09/17] common: add initial barebox deep-probe support Sascha Hauer
2021-04-19  7:16   ` Ahmad Fatoum
2021-04-26  8:15     ` Marco Felsch
2021-04-16  9:49 ` [PATCH 10/17] pinctrl: Find controller node first Sascha Hauer
2021-04-16  9:49 ` [PATCH 11/17] common: Explicitly probe consoles earlier with deep probe Sascha Hauer
2021-04-16  9:49 ` [PATCH 12/17] pinctrl: Add deep probe support Sascha Hauer
2021-04-16  9:49 ` [PATCH 13/17] ARM: i.MX: esdctl: add deep-probe support Sascha Hauer
2021-04-16  9:49 ` [PATCH 14/17] ARM: stm32mp: ddrctrl: " Sascha Hauer
2021-04-16  9:49 ` [PATCH 15/17] ARM: boards: mx6-sabrelite: " Sascha Hauer
2021-04-16  9:49 ` [PATCH 16/17] ARM: i.MX Phytec physom: convert to board driver Sascha Hauer
2021-04-16  9:49 ` [PATCH 17/17] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer
2021-04-19  7:12   ` Ahmad Fatoum
2021-04-26  9:20     ` Marco Felsch
2021-04-26  9:26       ` Marco Felsch
2021-04-26  9:36       ` Ahmad Fatoum
2021-04-26 10:03         ` Marco Felsch
2021-04-19  7:35 ` [PATCH v4 00/17] barebox deep probe support Ahmad Fatoum
2021-04-28 10:28 ` [PATCH 1/3] fixup! common: add initial barebox deep-probe support Marco Felsch
2021-04-28 10:28   ` [PATCH 2/3] fixup! ARM: boards: mx6-sabrelite: add " Marco Felsch
2021-04-28 10:28   ` [PATCH 3/3] fixup! ARM: i.MX Phytec physom: Add " Marco Felsch
2021-04-28 10:42   ` [PATCH 1/3] fixup! common: add initial barebox " Ahmad Fatoum
2021-04-28 10:48     ` Marco Felsch
2021-04-28 11:21   ` Marco Felsch
2021-05-03 11:54   ` Sascha Hauer
2021-05-06  9:28 [PATCH v5 00/17] barebox deep probe support Sascha Hauer
2021-05-06  9:28 ` [PATCH 05/17] of: base: move clock init from of_probe() to barebox_register_of() Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416094943.3648-6-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox