From: Michael Tretter <m.tretter@pengutronix.de>
To: Michael Graichen <michael.graichen@hotmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/1] Zynq: add support to chainload another barebox
Date: Mon, 17 May 2021 10:23:32 +0200 [thread overview]
Message-ID: <20210517082332.GA27865@pengutronix.de> (raw)
In-Reply-To: <AM9P192MB087024D17024B43EFE9CACAEAB599@AM9P192MB0870.EURP192.PROD.OUTLOOK.COM>
On Wed, 05 May 2021 09:40:29 +0000, Michael Graichen wrote:
[...]
> I'm currently booting from SDcard and i have not realised any problems with
> the FAT support so far. But with the arasan-sdhci driver when writing, see
> my patch below which fixes it for me but I haven't dived into the drivers
> very deeply yet.
>
> best regards
> Michael
>
>
> drivers/mci/arasan-sdhci.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c
> index 520bf30ff..669675369 100644
> --- a/drivers/mci/arasan-sdhci.c
> +++ b/drivers/mci/arasan-sdhci.c
> @@ -265,7 +265,7 @@ static int arasan_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
> if (cmd->cmdidx != MMC_CMD_STOP_TRANSMISSION)
> mask |= SDHCI_CMD_INHIBIT_DATA;
>
> - ret = wait_on_timeout(10 * MSECOND,
> + ret = wait_on_timeout(100 * MSECOND,
> !(sdhci_read32(&host->sdhci, SDHCI_PRESENT_STATE) & mask));
>
> if (ret) {
> @@ -277,8 +277,6 @@ static int arasan_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
> sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, ~0);
>
> mask = SDHCI_INT_CMD_COMPLETE;
> - if (data)
> - mask |= SDHCI_INT_DATA_AVAIL;
This looks familiar. I have a similar patch that sets SDHCI_INT_DATA_AVAIL
only if the command is a READ, but I didn't yet have time to verify, that this
is the correct fix.
Michael
>
> sdhci_set_cmd_xfer_mode(&host->sdhci, cmd, data, false, &command, &xfer);
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-05-17 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:07 Michael Graichen
2021-05-05 8:15 ` Lucas Stach
2021-05-05 8:27 ` Ahmad Fatoum
2021-05-05 9:40 ` AW: " Michael Graichen
2021-05-17 8:23 ` Michael Tretter [this message]
2021-05-18 8:09 ` Michael Graichen
2021-05-19 7:38 ` [PATCH 1/2] mci: arasan: wait for data available only on read Michael Tretter
2021-05-19 7:38 ` [PATCH 2/2] mci: arasan: configure data transfer only if we actually have data Michael Tretter
2021-05-25 7:17 ` Sascha Hauer
2021-05-25 7:16 ` [PATCH 1/2] mci: arasan: wait for data available only on read Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517082332.GA27865@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=michael.graichen@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox