mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Enrico Jorns <ejo@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro
Date: Tue, 18 May 2021 08:32:43 +0200	[thread overview]
Message-ID: <20210518063243.GV19819@pengutronix.de> (raw)
In-Reply-To: <20210517114519.28451-1-ejo@pengutronix.de>

On Mon, May 17, 2021 at 01:45:19PM +0200, Enrico Jorns wrote:
> dwc2_warn() is intended for printing 'warning' messages and should thus
> call dev_warn() instead of dev_err().
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  drivers/usb/dwc2/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index fa9d6ae954..c49672c85a 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -500,7 +500,7 @@ struct dwc2 {
>  #define gadget_to_dwc2(ptr) container_of(ptr, struct dwc2, gadget)
>  
>  #define dwc2_err(d, arg...) dev_err((d)->dev, ## arg)
> -#define dwc2_warn(d, arg...) dev_err((d)->dev, ## arg)
> +#define dwc2_warn(d, arg...) dev_warn((d)->dev, ## arg)
>  #define dwc2_info(d, arg...) dev_info((d)->dev, ## arg)
>  #define dwc2_dbg(d, arg...) dev_dbg((d)->dev, ## arg)
>  #define dwc2_vdbg(d, arg...) dev_vdbg((d)->dev, ## arg)
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-18  6:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 11:45 Enrico Jorns
2021-05-18  6:32 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210518063243.GV19819@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=ejo@pengutronix.de \
    --subject='Re: [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox