mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro
@ 2021-05-17 11:45 Enrico Jorns
  2021-05-18  6:32 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Enrico Jorns @ 2021-05-17 11:45 UTC (permalink / raw)
  To: barebox; +Cc: Enrico Jörns

dwc2_warn() is intended for printing 'warning' messages and should thus
call dev_warn() instead of dev_err().

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
---
 drivers/usb/dwc2/core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index fa9d6ae954..c49672c85a 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -500,7 +500,7 @@ struct dwc2 {
 #define gadget_to_dwc2(ptr) container_of(ptr, struct dwc2, gadget)
 
 #define dwc2_err(d, arg...) dev_err((d)->dev, ## arg)
-#define dwc2_warn(d, arg...) dev_err((d)->dev, ## arg)
+#define dwc2_warn(d, arg...) dev_warn((d)->dev, ## arg)
 #define dwc2_info(d, arg...) dev_info((d)->dev, ## arg)
 #define dwc2_dbg(d, arg...) dev_dbg((d)->dev, ## arg)
 #define dwc2_vdbg(d, arg...) dev_vdbg((d)->dev, ## arg)
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro
  2021-05-17 11:45 [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro Enrico Jorns
@ 2021-05-18  6:32 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-05-18  6:32 UTC (permalink / raw)
  To: Enrico Jorns; +Cc: barebox

On Mon, May 17, 2021 at 01:45:19PM +0200, Enrico Jorns wrote:
> dwc2_warn() is intended for printing 'warning' messages and should thus
> call dev_warn() instead of dev_err().
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  drivers/usb/dwc2/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index fa9d6ae954..c49672c85a 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -500,7 +500,7 @@ struct dwc2 {
>  #define gadget_to_dwc2(ptr) container_of(ptr, struct dwc2, gadget)
>  
>  #define dwc2_err(d, arg...) dev_err((d)->dev, ## arg)
> -#define dwc2_warn(d, arg...) dev_err((d)->dev, ## arg)
> +#define dwc2_warn(d, arg...) dev_warn((d)->dev, ## arg)
>  #define dwc2_info(d, arg...) dev_info((d)->dev, ## arg)
>  #define dwc2_dbg(d, arg...) dev_dbg((d)->dev, ## arg)
>  #define dwc2_vdbg(d, arg...) dev_vdbg((d)->dev, ## arg)
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-18  6:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 11:45 [PATCH] usb: dwc2: do no print error message with dwc2_warn() macro Enrico Jorns
2021-05-18  6:32 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git