mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
Date: Wed, 26 May 2021 09:18:00 +0200	[thread overview]
Message-ID: <20210526071800.GP31738@pengutronix.de> (raw)
In-Reply-To: <1e17f965a5a60aaba5b092785eb815dd7c4d83a0.camel@pengutronix.de>

On Thu, Apr 15, 2021 at 05:31:08PM +0200, Lucas Stach wrote:
> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
> > On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
> > > Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> > > > The SabreSD comes with different SoC variants. This patch adds support
> > > > for the i.MX6QP based board. the DCD data has been taken from U-Boot
> > > > 2021.04
> > > > 
> > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > > ---
> > > > 
> > > [...]
> > > > new file mode 100644
> > > > index 0000000000..52cc8aa73b
> > > > --- /dev/null
> > > > +++ b/arch/arm/dts/imx6qp-sabresd.dts
> > > > @@ -0,0 +1,42 @@
> > > > +/*
> > > > + * Copyright 2012 Freescale Semiconductor, Inc.
> > > > + * Copyright 2011 Linaro Ltd.
> > > > + *
> > > > + * The code contained herein is licensed under the GNU General Public
> > > > + * License. You may obtain a copy of the GNU General Public License
> > > > + * Version 2 or later at the following locations:
> > > > + *
> > > > + * http://www.opensource.org/licenses/gpl-license.html
> > > > + * http://www.gnu.org/copyleft/gpl.html
> > > > + */
> > > > +
> > > > +#include <arm/imx6qp-sabresd.dts>
> > > > +
> > > > +/ {
> > > > +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> > > > +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
> > > 
> > > I'm not sure I like this overwriting of the compatible string. AFAICS
> > > we don't have any instances for "fsl,imx6qp" compatible checks in
> > > either Barebox or Linux kernel, so it shouldn't cause any immediate
> > > damage, but this still feels wrong.
> > 
> > It's overwritten with the same strings as the included upstream dts has.
> > Anyway, as you say overwriting them here seems wrong. I removed it.
> 
> You had me confused for bit here, so I just checked and the compatible
> in the included upstream dts is different, as expected:
> 
> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";
> 
> So now that you removed those lines, does you board file need fixing
> for the different compatibles?

Yes, indeed.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-05-26  7:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 13:16 [PATCH 1/2] ARM: i.MX: Update sabresdb dcd data from U-Boot Sascha Hauer
2021-04-15 13:16 ` [PATCH 2/2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant Sascha Hauer
2021-04-15 14:03   ` [PATCH v2] " Sascha Hauer
2021-04-15 14:59     ` Lucas Stach
2021-04-15 15:12       ` Sascha Hauer
2021-04-15 15:31         ` Lucas Stach
2021-04-22 15:14           ` Bastian Krause
2021-05-25  8:54             ` Bastian Krause
2021-05-26  7:18               ` Sascha Hauer
2021-05-26  7:18           ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526071800.GP31738@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    --subject='Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox