mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: i.MX: Update sabresdb dcd data from U-Boot
@ 2021-04-15 13:16 Sascha Hauer
  2021-04-15 13:16 ` [PATCH 2/2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant Sascha Hauer
  0 siblings, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2021-04-15 13:16 UTC (permalink / raw)
  To: Barebox List

The DCD data for the SabreSD board goes back to 2013. This updates the
DCD data with the values from U-Boot-2021.04 which are likely better
maintained.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 .../flash-header-mx6-sabresd.imxcfg           | 144 +++++++-----------
 1 file changed, 53 insertions(+), 91 deletions(-)

diff --git a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg
index 133f499ab9..d0a0b40189 100644
--- a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg
+++ b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg
@@ -1,128 +1,90 @@
 loadaddr 0x10000000
 soc imx6
 ivtofs 0x400
+wm 32 0x20e056c 0x00020030
+wm 32 0x20e0578 0x00020030
+wm 32 0x20e0588 0x00020030
+wm 32 0x20e0594 0x00020030
+wm 32 0x20e0798 0x000C0000
+wm 32 0x20e0758 0x00000000
+wm 32 0x20e0588 0x00000030
+wm 32 0x20e0594 0x00000030
+wm 32 0x20e056c 0x00000030
+wm 32 0x20e0578 0x00000030
+wm 32 0x20e074c 0x00000030
+wm 32 0x20e057c 0x00000030
+wm 32 0x20e058c 0x00000000
+wm 32 0x20e059c 0x00000030
+wm 32 0x20e05a0 0x00000030
+wm 32 0x20e078c 0x00000030
+wm 32 0x20e0750 0x00020000
 wm 32 0x20e05a8 0x00000030
 wm 32 0x20e05b0 0x00000030
 wm 32 0x20e0524 0x00000030
 wm 32 0x20e051c 0x00000030
-
 wm 32 0x20e0518 0x00000030
 wm 32 0x20e050c 0x00000030
 wm 32 0x20e05b8 0x00000030
 wm 32 0x20e05c0 0x00000030
-
-wm 32 0x20e05ac 0x00020030
-wm 32 0x20e05b4 0x00020030
-wm 32 0x20e0528 0x00020030
-wm 32 0x20e0520 0x00020030
-
-wm 32 0x20e0514 0x00020030
-wm 32 0x20e0510 0x00020030
-wm 32 0x20e05bc 0x00020030
-wm 32 0x20e05c4 0x00020030
-
-wm 32 0x20e056c 0x00020030
-wm 32 0x20e0578 0x00020030
-wm 32 0x20e0588 0x00020030
-wm 32 0x20e0594 0x00020030
-
-wm 32 0x20e057c 0x00020030
-wm 32 0x20e0590 0x00003000
-wm 32 0x20e0598 0x00003000
-wm 32 0x20e058c 0x00000000
-
-wm 32 0x20e059c 0x00003030
-wm 32 0x20e05a0 0x00003030
+wm 32 0x20e0774 0x00020000
 wm 32 0x20e0784 0x00000030
 wm 32 0x20e0788 0x00000030
-
 wm 32 0x20e0794 0x00000030
 wm 32 0x20e079c 0x00000030
 wm 32 0x20e07a0 0x00000030
 wm 32 0x20e07a4 0x00000030
-
 wm 32 0x20e07a8 0x00000030
 wm 32 0x20e0748 0x00000030
-wm 32 0x20e074c 0x00000030
-wm 32 0x20e0750 0x00020000
-
-wm 32 0x20e0758 0x00000000
-wm 32 0x20e0774 0x00020000
-wm 32 0x20e078c 0x00000030
-wm 32 0x20e0798 0x000C0000
-
+wm 32 0x20e05ac 0x00000030
+wm 32 0x20e05b4 0x00000030
+wm 32 0x20e0528 0x00000030
+wm 32 0x20e0520 0x00000030
+wm 32 0x20e0514 0x00000030
+wm 32 0x20e0510 0x00000030
+wm 32 0x20e05bc 0x00000030
+wm 32 0x20e05c4 0x00000030
+wm 32 0x21b0800 0xa1390003
+wm 32 0x21b080c 0x001F001F
+wm 32 0x21b0810 0x001F001F
+wm 32 0x21b480c 0x001F001F
+wm 32 0x21b4810 0x001F001F
+wm 32 0x21b083c 0x43270338
+wm 32 0x21b0840 0x03200314
+wm 32 0x21b483c 0x431A032F
+wm 32 0x21b4840 0x03200263
+wm 32 0x21b0848 0x4B434748
+wm 32 0x21b4848 0x4445404C
+wm 32 0x21b0850 0x38444542
+wm 32 0x21b4850 0x4935493A
 wm 32 0x21b081c 0x33333333
 wm 32 0x21b0820 0x33333333
 wm 32 0x21b0824 0x33333333
 wm 32 0x21b0828 0x33333333
-
 wm 32 0x21b481c 0x33333333
 wm 32 0x21b4820 0x33333333
 wm 32 0x21b4824 0x33333333
 wm 32 0x21b4828 0x33333333
-
-wm 32 0x21b0018 0x00081740
-
-wm 32 0x21b001c 0x00008000
+wm 32 0x21b08b8 0x00000800
+wm 32 0x21b48b8 0x00000800
+wm 32 0x21b0004 0x00020036
+wm 32 0x21b0008 0x09444040
 wm 32 0x21b000c 0x555A7975
-wm 32 0x21b0010 0xFF538E64
+wm 32 0x21b0010 0xFF538F64
 wm 32 0x21b0014 0x01FF00DB
-wm 32 0x21b002c 0x000026D2
-
-wm 32 0x21b0030 0x005B0E21
-wm 32 0x21b0008 0x09444040
-wm 32 0x21b0004 0x00025576
+wm 32 0x21b0018 0x00001740
+wm 32 0x21b001c 0x00008000
+wm 32 0x21b002c 0x000026d2
+wm 32 0x21b0030 0x005A1023
 wm 32 0x21b0040 0x00000027
 wm 32 0x21b0000 0x831A0000
-
 wm 32 0x21b001c 0x04088032
-wm 32 0x21b001c 0x0408803A
 wm 32 0x21b001c 0x00008033
-wm 32 0x21b001c 0x0000803B
-wm 32 0x21b001c 0x00428031
-wm 32 0x21b001c 0x00428039
+wm 32 0x21b001c 0x00048031
 wm 32 0x21b001c 0x09408030
-wm 32 0x21b001c 0x09408038
-
 wm 32 0x21b001c 0x04008040
-wm 32 0x21b001c 0x04008048
-wm 32 0x21b0800 0xA1380003
-wm 32 0x21b4800 0xA1380003
 wm 32 0x21b0020 0x00005800
-wm 32 0x21b0818 0x00022227
-wm 32 0x21b4818 0x00022227
-
-wm 32 0x21b083c 0x434B0350
-wm 32 0x21b0840 0x034C0359
-wm 32 0x21b483c 0x434B0350
-wm 32 0x21b4840 0x03650348
-wm 32 0x21b0848 0x4436383B
-wm 32 0x21b4848 0x39393341
-wm 32 0x21b0850 0x35373933
-wm 32 0x21b4850 0x48254A36
-
-wm 32 0x21b080c 0x001F001F
-wm 32 0x21b0810 0x001F001F
-
-wm 32 0x21b480c 0x00440044
-wm 32 0x21b4810 0x00440044
-
-wm 32 0x21b08b8 0x00000800
-wm 32 0x21b48b8 0x00000800
-
-wm 32 0x21b001c 0x00000000
+wm 32 0x21b0818 0x00011117
+wm 32 0x21b4818 0x00011117
+wm 32 0x21b0004 0x00025576
 wm 32 0x21b0404 0x00011006
-
-wm 32 0x020c4068 0x00c03f3f
-wm 32 0x020c406c 0x0030fc03
-wm 32 0x020c4070 0x0fffc000
-wm 32 0x020c4074 0x3ff00000
-wm 32 0x020c4078 0x00fff300
-wm 32 0x020c407c 0x0f0000c3
-wm 32 0x020c4080 0x000003ff
-
-# enable AXI cache for VDOA/VPU/IPU
-wm 32 0x20e0010 0xf00000cf
-# set IPU AXI-id0 Qos=0xf(bypass) AXI-id1 Qos=0x7
-wm 32 0x20e0018 0x007f007f
-wm 32 0x20e001c 0x007f007f
+wm 32 0x21b001c 0x00000000
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 13:16 [PATCH 1/2] ARM: i.MX: Update sabresdb dcd data from U-Boot Sascha Hauer
@ 2021-04-15 13:16 ` Sascha Hauer
  2021-04-15 14:03   ` [PATCH v2] " Sascha Hauer
  0 siblings, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2021-04-15 13:16 UTC (permalink / raw)
  To: Barebox List

The SabreSD comes with different SoC variants. This patch adds support
for the i.MX6QP based board. the DCD data has been taken from U-Boot
2021.04

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 ...mxcfg => flash-header-mx6q-sabresd.imxcfg} |  0
 .../flash-header-mx6qp-sabresd.imxcfg         | 96 +++++++++++++++++++
 .../boards/freescale-mx6-sabresd/lowlevel.c   | 16 ++++
 arch/arm/dts/Makefile                         |  2 +-
 images/Makefile.imx                           |  4 +-
 5 files changed, 116 insertions(+), 2 deletions(-)
 rename arch/arm/boards/freescale-mx6-sabresd/{flash-header-mx6-sabresd.imxcfg => flash-header-mx6q-sabresd.imxcfg} (100%)
 create mode 100644 arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg

diff --git a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6q-sabresd.imxcfg
similarity index 100%
rename from arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg
rename to arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6q-sabresd.imxcfg
diff --git a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
new file mode 100644
index 0000000000..aa52776afb
--- /dev/null
+++ b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
@@ -0,0 +1,96 @@
+loadaddr 0x10000000
+soc imx6
+ivtofs 0x400
+wm 32 0x20e0798 0x000c0000
+wm 32 0x20e0758 0x00000000
+wm 32 0x20e0588 0x00000030
+wm 32 0x20e0594 0x00000030
+wm 32 0x20e056c 0x00000030
+wm 32 0x20e0578 0x00000030
+wm 32 0x20e074c 0x00000030
+wm 32 0x20e057c 0x00000030
+wm 32 0x20e058c 0x00000000
+wm 32 0x20e059c 0x00000030
+wm 32 0x20e05a0 0x00000030
+wm 32 0x20e078c 0x00000030
+wm 32 0x20e0750 0x00020000
+wm 32 0x20e05a8 0x00000030
+wm 32 0x20e05b0 0x00000030
+wm 32 0x20e0524 0x00000030
+wm 32 0x20e051c 0x00000030
+wm 32 0x20e0518 0x00000030
+wm 32 0x20e050c 0x00000030
+wm 32 0x20e05b8 0x00000030
+wm 32 0x20e05c0 0x00000030
+wm 32 0x20e0774 0x00020000
+wm 32 0x20e0784 0x00000030
+wm 32 0x20e0788 0x00000030
+wm 32 0x20e0794 0x00000030
+wm 32 0x20e079c 0x00000030
+wm 32 0x20e07a0 0x00000030
+wm 32 0x20e07a4 0x00000030
+wm 32 0x20e07a8 0x00000030
+wm 32 0x20e0748 0x00000030
+wm 32 0x20e05ac 0x00000030
+wm 32 0x20e05b4 0x00000030
+wm 32 0x20e0528 0x00000030
+wm 32 0x20e0520 0x00000030
+wm 32 0x20e0514 0x00000030
+wm 32 0x20e0510 0x00000030
+wm 32 0x20e05bc 0x00000030
+wm 32 0x20e05c4 0x00000030
+wm 32 0x21b0800 0xa1390003
+wm 32 0x21b080c 0x001b001e
+wm 32 0x21b0810 0x002e0029
+wm 32 0x21b480c 0x001b002a
+wm 32 0x21b4810 0x0019002c
+wm 32 0x21b083c 0x43240334
+wm 32 0x21b0840 0x0324031a
+wm 32 0x21b483c 0x43340344
+wm 32 0x21b4840 0x03280276
+wm 32 0x21b0848 0x44383A3E
+wm 32 0x21b4848 0x3C3C3846
+wm 32 0x21b0850 0x2e303230
+wm 32 0x21b4850 0x38283E34
+wm 32 0x21b081c 0x33333333
+wm 32 0x21b0820 0x33333333
+wm 32 0x21b0824 0x33333333
+wm 32 0x21b0828 0x33333333
+wm 32 0x21b481c 0x33333333
+wm 32 0x21b4820 0x33333333
+wm 32 0x21b4824 0x33333333
+wm 32 0x21b4828 0x33333333
+wm 32 0x21b08c0 0x24912249
+wm 32 0x21b48c0 0x24914289
+wm 32 0x21b08b8 0x00000800
+wm 32 0x21b48b8 0x00000800
+wm 32 0x21b0004 0x00020036
+wm 32 0x21b0008 0x24444040
+wm 32 0x21b000c 0x555A7955
+wm 32 0x21b0010 0xFF320F64
+wm 32 0x21b0014 0x01ff00db
+wm 32 0x21b0018 0x00001740
+wm 32 0x21b001c 0x00008000
+wm 32 0x21b002c 0x000026d2
+wm 32 0x21b0030 0x005A1023
+wm 32 0x21b0040 0x00000027
+wm 32 0x21b0400 0x14420000
+wm 32 0x21b0000 0x831A0000
+wm 32 0x21b0890 0x00400C58
+wm 32 0x0bb0008 0x00000000
+wm 32 0x0bb000c 0x2891E41A
+wm 32 0x0bb0038 0x00000564
+wm 32 0x0bb0014 0x00000040
+wm 32 0x0bb0028 0x00000020
+wm 32 0x0bb002c 0x00000020
+wm 32 0x21b001c 0x04088032
+wm 32 0x21b001c 0x00008033
+wm 32 0x21b001c 0x00048031
+wm 32 0x21b001c 0x09408030
+wm 32 0x21b001c 0x04008040
+wm 32 0x21b0020 0x00005800
+wm 32 0x21b0818 0x00011117
+wm 32 0x21b4818 0x00011117
+wm 32 0x21b0004 0x00025576
+wm 32 0x21b0404 0x00011006
+wm 32 0x21b001c 0x00000000
diff --git a/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c b/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
index ae847feaa6..7f83366e7a 100644
--- a/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
+++ b/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
@@ -35,3 +35,19 @@ ENTRY_FUNCTION(start_imx6q_sabresd, r0, r1, r2)
 
 	barebox_arm_entry(0x10000000, SZ_1G, fdt);
 }
+
+extern char __dtb_imx6qp_sabresd_start[];
+
+ENTRY_FUNCTION(start_imx6qp_sabresd, r0, r1, r2)
+{
+	void *fdt;
+
+	imx6_cpu_lowlevel_init();
+
+	if (IS_ENABLED(CONFIG_DEBUG_LL))
+		setup_uart();
+
+	fdt = __dtb_imx6qp_sabresd_start + get_runtime_offset();
+
+	barebox_arm_entry(0x10000000, SZ_1G, fdt);
+}
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index a637869fb6..795087f41b 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -100,7 +100,7 @@ lwl-$(CONFIG_MACH_RPI2) += bcm2836-rpi-2.dtb.o
 lwl-$(CONFIG_MACH_RPI3) += bcm2837-rpi-3.dtb.o
 lwl-$(CONFIG_MACH_RPI_CM3) += bcm2837-rpi-cm3.dtb.o
 lwl-$(CONFIG_MACH_SABRELITE) += imx6q-sabrelite.dtb.o imx6dl-sabrelite.dtb.o
-lwl-$(CONFIG_MACH_SABRESD) += imx6q-sabresd.dtb.o
+lwl-$(CONFIG_MACH_SABRESD) += imx6q-sabresd.dtb.o imx6qp-sabresd.dtb.o
 lwl-$(CONFIG_MACH_FREESCALE_IMX6SX_SABRESDB) += imx6sx-sdb.dtb.o
 lwl-$(CONFIG_MACH_SOCFPGA_ALTERA_SOCDK) += socfpga_cyclone5_socdk.dtb.o
 lwl-$(CONFIG_MACH_SOCFPGA_EBV_SOCRATES) += socfpga_cyclone5_socrates.dtb.o
diff --git a/images/Makefile.imx b/images/Makefile.imx
index 382493488b..3f3cb40d93 100644
--- a/images/Makefile.imx
+++ b/images/Makefile.imx
@@ -215,7 +215,9 @@ $(call build_imx_habv4img, CONFIG_MACH_SABRELITE, start_imx6q_sabrelite, freesca
 
 $(call build_imx_habv4img, CONFIG_MACH_SABRELITE, start_imx6dl_sabrelite, freescale-mx6-sabrelite/flash-header-mx6-sabrelite, freescale-imx6dl-sabrelite)
 
-$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6q_sabresd, freescale-mx6-sabresd/flash-header-mx6-sabresd, freescale-imx6q-sabresd)
+$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6q_sabresd, freescale-mx6-sabresd/flash-header-mx6q-sabresd, freescale-imx6q-sabresd)
+
+$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6qp_sabresd, freescale-mx6-sabresd/flash-header-mx6qp-sabresd, freescale-imx6qp-sabresd)
 
 $(call build_imx_habv4img, CONFIG_MACH_UDOO_NEO, start_imx6sx_udoo_neo, udoo-neo/flash-header-mx6sx-udoo-neo_full, udoo-neo)
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 13:16 ` [PATCH 2/2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant Sascha Hauer
@ 2021-04-15 14:03   ` Sascha Hauer
  2021-04-15 14:59     ` Lucas Stach
  0 siblings, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2021-04-15 14:03 UTC (permalink / raw)
  To: Barebox List

The SabreSD comes with different SoC variants. This patch adds support
for the i.MX6QP based board. the DCD data has been taken from U-Boot
2021.04

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---

v2: Add missing arch/arm/dts/imx6qp-sabresd.dts

 ...mxcfg => flash-header-mx6q-sabresd.imxcfg} |  0
 .../flash-header-mx6qp-sabresd.imxcfg         | 96 +++++++++++++++++++
 .../boards/freescale-mx6-sabresd/lowlevel.c   | 16 ++++
 arch/arm/dts/Makefile                         |  2 +-
 arch/arm/dts/imx6qp-sabresd.dts               | 42 ++++++++
 images/Makefile.imx                           |  4 +-
 6 files changed, 158 insertions(+), 2 deletions(-)
 rename arch/arm/boards/freescale-mx6-sabresd/{flash-header-mx6-sabresd.imxcfg => flash-header-mx6q-sabresd.imxcfg} (100%)
 create mode 100644 arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
 create mode 100644 arch/arm/dts/imx6qp-sabresd.dts

diff --git a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6q-sabresd.imxcfg
similarity index 100%
rename from arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.imxcfg
rename to arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6q-sabresd.imxcfg
diff --git a/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
new file mode 100644
index 0000000000..aa52776afb
--- /dev/null
+++ b/arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
@@ -0,0 +1,96 @@
+loadaddr 0x10000000
+soc imx6
+ivtofs 0x400
+wm 32 0x20e0798 0x000c0000
+wm 32 0x20e0758 0x00000000
+wm 32 0x20e0588 0x00000030
+wm 32 0x20e0594 0x00000030
+wm 32 0x20e056c 0x00000030
+wm 32 0x20e0578 0x00000030
+wm 32 0x20e074c 0x00000030
+wm 32 0x20e057c 0x00000030
+wm 32 0x20e058c 0x00000000
+wm 32 0x20e059c 0x00000030
+wm 32 0x20e05a0 0x00000030
+wm 32 0x20e078c 0x00000030
+wm 32 0x20e0750 0x00020000
+wm 32 0x20e05a8 0x00000030
+wm 32 0x20e05b0 0x00000030
+wm 32 0x20e0524 0x00000030
+wm 32 0x20e051c 0x00000030
+wm 32 0x20e0518 0x00000030
+wm 32 0x20e050c 0x00000030
+wm 32 0x20e05b8 0x00000030
+wm 32 0x20e05c0 0x00000030
+wm 32 0x20e0774 0x00020000
+wm 32 0x20e0784 0x00000030
+wm 32 0x20e0788 0x00000030
+wm 32 0x20e0794 0x00000030
+wm 32 0x20e079c 0x00000030
+wm 32 0x20e07a0 0x00000030
+wm 32 0x20e07a4 0x00000030
+wm 32 0x20e07a8 0x00000030
+wm 32 0x20e0748 0x00000030
+wm 32 0x20e05ac 0x00000030
+wm 32 0x20e05b4 0x00000030
+wm 32 0x20e0528 0x00000030
+wm 32 0x20e0520 0x00000030
+wm 32 0x20e0514 0x00000030
+wm 32 0x20e0510 0x00000030
+wm 32 0x20e05bc 0x00000030
+wm 32 0x20e05c4 0x00000030
+wm 32 0x21b0800 0xa1390003
+wm 32 0x21b080c 0x001b001e
+wm 32 0x21b0810 0x002e0029
+wm 32 0x21b480c 0x001b002a
+wm 32 0x21b4810 0x0019002c
+wm 32 0x21b083c 0x43240334
+wm 32 0x21b0840 0x0324031a
+wm 32 0x21b483c 0x43340344
+wm 32 0x21b4840 0x03280276
+wm 32 0x21b0848 0x44383A3E
+wm 32 0x21b4848 0x3C3C3846
+wm 32 0x21b0850 0x2e303230
+wm 32 0x21b4850 0x38283E34
+wm 32 0x21b081c 0x33333333
+wm 32 0x21b0820 0x33333333
+wm 32 0x21b0824 0x33333333
+wm 32 0x21b0828 0x33333333
+wm 32 0x21b481c 0x33333333
+wm 32 0x21b4820 0x33333333
+wm 32 0x21b4824 0x33333333
+wm 32 0x21b4828 0x33333333
+wm 32 0x21b08c0 0x24912249
+wm 32 0x21b48c0 0x24914289
+wm 32 0x21b08b8 0x00000800
+wm 32 0x21b48b8 0x00000800
+wm 32 0x21b0004 0x00020036
+wm 32 0x21b0008 0x24444040
+wm 32 0x21b000c 0x555A7955
+wm 32 0x21b0010 0xFF320F64
+wm 32 0x21b0014 0x01ff00db
+wm 32 0x21b0018 0x00001740
+wm 32 0x21b001c 0x00008000
+wm 32 0x21b002c 0x000026d2
+wm 32 0x21b0030 0x005A1023
+wm 32 0x21b0040 0x00000027
+wm 32 0x21b0400 0x14420000
+wm 32 0x21b0000 0x831A0000
+wm 32 0x21b0890 0x00400C58
+wm 32 0x0bb0008 0x00000000
+wm 32 0x0bb000c 0x2891E41A
+wm 32 0x0bb0038 0x00000564
+wm 32 0x0bb0014 0x00000040
+wm 32 0x0bb0028 0x00000020
+wm 32 0x0bb002c 0x00000020
+wm 32 0x21b001c 0x04088032
+wm 32 0x21b001c 0x00008033
+wm 32 0x21b001c 0x00048031
+wm 32 0x21b001c 0x09408030
+wm 32 0x21b001c 0x04008040
+wm 32 0x21b0020 0x00005800
+wm 32 0x21b0818 0x00011117
+wm 32 0x21b4818 0x00011117
+wm 32 0x21b0004 0x00025576
+wm 32 0x21b0404 0x00011006
+wm 32 0x21b001c 0x00000000
diff --git a/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c b/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
index ae847feaa6..7f83366e7a 100644
--- a/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
+++ b/arch/arm/boards/freescale-mx6-sabresd/lowlevel.c
@@ -35,3 +35,19 @@ ENTRY_FUNCTION(start_imx6q_sabresd, r0, r1, r2)
 
 	barebox_arm_entry(0x10000000, SZ_1G, fdt);
 }
+
+extern char __dtb_imx6qp_sabresd_start[];
+
+ENTRY_FUNCTION(start_imx6qp_sabresd, r0, r1, r2)
+{
+	void *fdt;
+
+	imx6_cpu_lowlevel_init();
+
+	if (IS_ENABLED(CONFIG_DEBUG_LL))
+		setup_uart();
+
+	fdt = __dtb_imx6qp_sabresd_start + get_runtime_offset();
+
+	barebox_arm_entry(0x10000000, SZ_1G, fdt);
+}
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index a637869fb6..795087f41b 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -100,7 +100,7 @@ lwl-$(CONFIG_MACH_RPI2) += bcm2836-rpi-2.dtb.o
 lwl-$(CONFIG_MACH_RPI3) += bcm2837-rpi-3.dtb.o
 lwl-$(CONFIG_MACH_RPI_CM3) += bcm2837-rpi-cm3.dtb.o
 lwl-$(CONFIG_MACH_SABRELITE) += imx6q-sabrelite.dtb.o imx6dl-sabrelite.dtb.o
-lwl-$(CONFIG_MACH_SABRESD) += imx6q-sabresd.dtb.o
+lwl-$(CONFIG_MACH_SABRESD) += imx6q-sabresd.dtb.o imx6qp-sabresd.dtb.o
 lwl-$(CONFIG_MACH_FREESCALE_IMX6SX_SABRESDB) += imx6sx-sdb.dtb.o
 lwl-$(CONFIG_MACH_SOCFPGA_ALTERA_SOCDK) += socfpga_cyclone5_socdk.dtb.o
 lwl-$(CONFIG_MACH_SOCFPGA_EBV_SOCRATES) += socfpga_cyclone5_socrates.dtb.o
diff --git a/arch/arm/dts/imx6qp-sabresd.dts b/arch/arm/dts/imx6qp-sabresd.dts
new file mode 100644
index 0000000000..52cc8aa73b
--- /dev/null
+++ b/arch/arm/dts/imx6qp-sabresd.dts
@@ -0,0 +1,42 @@
+/*
+ * Copyright 2012 Freescale Semiconductor, Inc.
+ * Copyright 2011 Linaro Ltd.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include <arm/imx6qp-sabresd.dts>
+
+/ {
+	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
+	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
+
+	chosen {
+		stdout-path = &uart1;
+
+		environment {
+			compatible = "barebox,environment";
+			device-path = &environment_usdhc3;
+		};
+	};
+};
+
+&usdhc3 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	partition@0 {
+		label = "barebox";
+		reg = <0x0 0xe0000>;
+	};
+
+	environment_usdhc3: partition@e0000 {
+		label = "barebox-environment";
+		reg = <0xe0000 0x20000>;
+	};
+};
diff --git a/images/Makefile.imx b/images/Makefile.imx
index 382493488b..3f3cb40d93 100644
--- a/images/Makefile.imx
+++ b/images/Makefile.imx
@@ -215,7 +215,9 @@ $(call build_imx_habv4img, CONFIG_MACH_SABRELITE, start_imx6q_sabrelite, freesca
 
 $(call build_imx_habv4img, CONFIG_MACH_SABRELITE, start_imx6dl_sabrelite, freescale-mx6-sabrelite/flash-header-mx6-sabrelite, freescale-imx6dl-sabrelite)
 
-$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6q_sabresd, freescale-mx6-sabresd/flash-header-mx6-sabresd, freescale-imx6q-sabresd)
+$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6q_sabresd, freescale-mx6-sabresd/flash-header-mx6q-sabresd, freescale-imx6q-sabresd)
+
+$(call build_imx_habv4img, CONFIG_MACH_SABRESD, start_imx6qp_sabresd, freescale-mx6-sabresd/flash-header-mx6qp-sabresd, freescale-imx6qp-sabresd)
 
 $(call build_imx_habv4img, CONFIG_MACH_UDOO_NEO, start_imx6sx_udoo_neo, udoo-neo/flash-header-mx6sx-udoo-neo_full, udoo-neo)
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 14:03   ` [PATCH v2] " Sascha Hauer
@ 2021-04-15 14:59     ` Lucas Stach
  2021-04-15 15:12       ` Sascha Hauer
  0 siblings, 1 reply; 10+ messages in thread
From: Lucas Stach @ 2021-04-15 14:59 UTC (permalink / raw)
  To: Sascha Hauer, Barebox List

Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> The SabreSD comes with different SoC variants. This patch adds support
> for the i.MX6QP based board. the DCD data has been taken from U-Boot
> 2021.04
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> 
[...]
> new file mode 100644
> index 0000000000..52cc8aa73b
> --- /dev/null
> +++ b/arch/arm/dts/imx6qp-sabresd.dts
> @@ -0,0 +1,42 @@
> +/*
> + * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2011 Linaro Ltd.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +#include <arm/imx6qp-sabresd.dts>
> +
> +/ {
> +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";

I'm not sure I like this overwriting of the compatible string. AFAICS
we don't have any instances for "fsl,imx6qp" compatible checks in
either Barebox or Linux kernel, so it shouldn't cause any immediate
damage, but this still feels wrong.

Regards,
Lucas

> +
> +	chosen {
> +		stdout-path = &uart1;
> +
> +		environment {
> +			compatible = "barebox,environment";
> +			device-path = &environment_usdhc3;
> +		};
> +	};
> +};
> +
> +&usdhc3 {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	partition@0 {
> +		label = "barebox";
> +		reg = <0x0 0xe0000>;
> +	};
> +
> +	environment_usdhc3: partition@e0000 {
> +		label = "barebox-environment";
> +		reg = <0xe0000 0x20000>;
> +	};
> +};



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 14:59     ` Lucas Stach
@ 2021-04-15 15:12       ` Sascha Hauer
  2021-04-15 15:31         ` Lucas Stach
  0 siblings, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2021-04-15 15:12 UTC (permalink / raw)
  To: Lucas Stach; +Cc: Barebox List

On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> > The SabreSD comes with different SoC variants. This patch adds support
> > for the i.MX6QP based board. the DCD data has been taken from U-Boot
> > 2021.04
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > 
> [...]
> > new file mode 100644
> > index 0000000000..52cc8aa73b
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qp-sabresd.dts
> > @@ -0,0 +1,42 @@
> > +/*
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + * Copyright 2011 Linaro Ltd.
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 or later at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +#include <arm/imx6qp-sabresd.dts>
> > +
> > +/ {
> > +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> > +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
> 
> I'm not sure I like this overwriting of the compatible string. AFAICS
> we don't have any instances for "fsl,imx6qp" compatible checks in
> either Barebox or Linux kernel, so it shouldn't cause any immediate
> damage, but this still feels wrong.

It's overwritten with the same strings as the included upstream dts has.
Anyway, as you say overwriting them here seems wrong. I removed it.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 15:12       ` Sascha Hauer
@ 2021-04-15 15:31         ` Lucas Stach
  2021-04-22 15:14           ` Bastian Krause
  2021-05-26  7:18           ` Sascha Hauer
  0 siblings, 2 replies; 10+ messages in thread
From: Lucas Stach @ 2021-04-15 15:31 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Barebox List

Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
> > Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> > > The SabreSD comes with different SoC variants. This patch adds support
> > > for the i.MX6QP based board. the DCD data has been taken from U-Boot
> > > 2021.04
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > > 
> > [...]
> > > new file mode 100644
> > > index 0000000000..52cc8aa73b
> > > --- /dev/null
> > > +++ b/arch/arm/dts/imx6qp-sabresd.dts
> > > @@ -0,0 +1,42 @@
> > > +/*
> > > + * Copyright 2012 Freescale Semiconductor, Inc.
> > > + * Copyright 2011 Linaro Ltd.
> > > + *
> > > + * The code contained herein is licensed under the GNU General Public
> > > + * License. You may obtain a copy of the GNU General Public License
> > > + * Version 2 or later at the following locations:
> > > + *
> > > + * http://www.opensource.org/licenses/gpl-license.html
> > > + * http://www.gnu.org/copyleft/gpl.html
> > > + */
> > > +
> > > +#include <arm/imx6qp-sabresd.dts>
> > > +
> > > +/ {
> > > +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> > > +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
> > 
> > I'm not sure I like this overwriting of the compatible string. AFAICS
> > we don't have any instances for "fsl,imx6qp" compatible checks in
> > either Barebox or Linux kernel, so it shouldn't cause any immediate
> > damage, but this still feels wrong.
> 
> It's overwritten with the same strings as the included upstream dts has.
> Anyway, as you say overwriting them here seems wrong. I removed it.

You had me confused for bit here, so I just checked and the compatible
in the included upstream dts is different, as expected:

compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";

So now that you removed those lines, does you board file need fixing
for the different compatibles?

Regards,
Lucas


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 15:31         ` Lucas Stach
@ 2021-04-22 15:14           ` Bastian Krause
  2021-05-25  8:54             ` Bastian Krause
  2021-05-26  7:18           ` Sascha Hauer
  1 sibling, 1 reply; 10+ messages in thread
From: Bastian Krause @ 2021-04-22 15:14 UTC (permalink / raw)
  To: Lucas Stach, Sascha Hauer; +Cc: Barebox List

On 4/15/21 5:31 PM, Lucas Stach wrote:
> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
>> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
>>> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
>>>> The SabreSD comes with different SoC variants. This patch adds support
>>>> for the i.MX6QP based board. the DCD data has been taken from U-Boot
>>>> 2021.04
>>>>
>>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>>>> ---
>>>>
>>> [...]
>>>> new file mode 100644
>>>> index 0000000000..52cc8aa73b
>>>> --- /dev/null
>>>> +++ b/arch/arm/dts/imx6qp-sabresd.dts
>>>> @@ -0,0 +1,42 @@
>>>> +/*
>>>> + * Copyright 2012 Freescale Semiconductor, Inc.
>>>> + * Copyright 2011 Linaro Ltd.
>>>> + *
>>>> + * The code contained herein is licensed under the GNU General Public
>>>> + * License. You may obtain a copy of the GNU General Public License
>>>> + * Version 2 or later at the following locations:
>>>> + *
>>>> + * http://www.opensource.org/licenses/gpl-license.html
>>>> + * http://www.gnu.org/copyleft/gpl.html
>>>> + */
>>>> +
>>>> +#include <arm/imx6qp-sabresd.dts>
>>>> +
>>>> +/ {
>>>> +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
>>>> +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
>>>
>>> I'm not sure I like this overwriting of the compatible string. AFAICS
>>> we don't have any instances for "fsl,imx6qp" compatible checks in
>>> either Barebox or Linux kernel, so it shouldn't cause any immediate
>>> damage, but this still feels wrong.
>>
>> It's overwritten with the same strings as the included upstream dts has.
>> Anyway, as you say overwriting them here seems wrong. I removed it.
> 
> You had me confused for bit here, so I just checked and the compatible
> in the included upstream dts is different, as expected:
> 
> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";
> 
> So now that you removed those lines, does you board file need fixing
> for the different compatibles?

My board works fine (bootspec-wise) with the dropped compatible.

Regards,
Bastian

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-22 15:14           ` Bastian Krause
@ 2021-05-25  8:54             ` Bastian Krause
  2021-05-26  7:18               ` Sascha Hauer
  0 siblings, 1 reply; 10+ messages in thread
From: Bastian Krause @ 2021-05-25  8:54 UTC (permalink / raw)
  To: Lucas Stach, Sascha Hauer; +Cc: Barebox List

On 4/22/21 5:14 PM, Bastian Krause wrote:
> On 4/15/21 5:31 PM, Lucas Stach wrote:
>> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
>>> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
>>>> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
>>>>> The SabreSD comes with different SoC variants. This patch adds support
>>>>> for the i.MX6QP based board. the DCD data has been taken from U-Boot
>>>>> 2021.04
>>>>>
>>>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>>>>> ---
>>>>>
>>>> [...]
>>>>> new file mode 100644
>>>>> index 0000000000..52cc8aa73b
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/dts/imx6qp-sabresd.dts
>>>>> @@ -0,0 +1,42 @@
>>>>> +/*
>>>>> + * Copyright 2012 Freescale Semiconductor, Inc.
>>>>> + * Copyright 2011 Linaro Ltd.
>>>>> + *
>>>>> + * The code contained herein is licensed under the GNU General Public
>>>>> + * License. You may obtain a copy of the GNU General Public License
>>>>> + * Version 2 or later at the following locations:
>>>>> + *
>>>>> + * http://www.opensource.org/licenses/gpl-license.html
>>>>> + * http://www.gnu.org/copyleft/gpl.html
>>>>> + */
>>>>> +
>>>>> +#include <arm/imx6qp-sabresd.dts>
>>>>> +
>>>>> +/ {
>>>>> +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
>>>>> +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
>>>>
>>>> I'm not sure I like this overwriting of the compatible string. AFAICS
>>>> we don't have any instances for "fsl,imx6qp" compatible checks in
>>>> either Barebox or Linux kernel, so it shouldn't cause any immediate
>>>> damage, but this still feels wrong.
>>>
>>> It's overwritten with the same strings as the included upstream dts has.
>>> Anyway, as you say overwriting them here seems wrong. I removed it.
>>
>> You had me confused for bit here, so I just checked and the compatible
>> in the included upstream dts is different, as expected:
>>
>> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";
>>
>> So now that you removed those lines, does you board file need fixing
>> for the different compatibles?
> 
> My board works fine (bootspec-wise) with the dropped compatible.

What's the state of this patch, Sascha?

Regards,
Bastian

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-04-15 15:31         ` Lucas Stach
  2021-04-22 15:14           ` Bastian Krause
@ 2021-05-26  7:18           ` Sascha Hauer
  1 sibling, 0 replies; 10+ messages in thread
From: Sascha Hauer @ 2021-05-26  7:18 UTC (permalink / raw)
  To: Lucas Stach; +Cc: Barebox List

On Thu, Apr 15, 2021 at 05:31:08PM +0200, Lucas Stach wrote:
> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
> > On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
> > > Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> > > > The SabreSD comes with different SoC variants. This patch adds support
> > > > for the i.MX6QP based board. the DCD data has been taken from U-Boot
> > > > 2021.04
> > > > 
> > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > > ---
> > > > 
> > > [...]
> > > > new file mode 100644
> > > > index 0000000000..52cc8aa73b
> > > > --- /dev/null
> > > > +++ b/arch/arm/dts/imx6qp-sabresd.dts
> > > > @@ -0,0 +1,42 @@
> > > > +/*
> > > > + * Copyright 2012 Freescale Semiconductor, Inc.
> > > > + * Copyright 2011 Linaro Ltd.
> > > > + *
> > > > + * The code contained herein is licensed under the GNU General Public
> > > > + * License. You may obtain a copy of the GNU General Public License
> > > > + * Version 2 or later at the following locations:
> > > > + *
> > > > + * http://www.opensource.org/licenses/gpl-license.html
> > > > + * http://www.gnu.org/copyleft/gpl.html
> > > > + */
> > > > +
> > > > +#include <arm/imx6qp-sabresd.dts>
> > > > +
> > > > +/ {
> > > > +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> > > > +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
> > > 
> > > I'm not sure I like this overwriting of the compatible string. AFAICS
> > > we don't have any instances for "fsl,imx6qp" compatible checks in
> > > either Barebox or Linux kernel, so it shouldn't cause any immediate
> > > damage, but this still feels wrong.
> > 
> > It's overwritten with the same strings as the included upstream dts has.
> > Anyway, as you say overwriting them here seems wrong. I removed it.
> 
> You had me confused for bit here, so I just checked and the compatible
> in the included upstream dts is different, as expected:
> 
> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";
> 
> So now that you removed those lines, does you board file need fixing
> for the different compatibles?

Yes, indeed.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
  2021-05-25  8:54             ` Bastian Krause
@ 2021-05-26  7:18               ` Sascha Hauer
  0 siblings, 0 replies; 10+ messages in thread
From: Sascha Hauer @ 2021-05-26  7:18 UTC (permalink / raw)
  To: Bastian Krause; +Cc: Barebox List

On Tue, May 25, 2021 at 10:54:44AM +0200, Bastian Krause wrote:
> On 4/22/21 5:14 PM, Bastian Krause wrote:
> > On 4/15/21 5:31 PM, Lucas Stach wrote:
> >> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer:
> >>> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote:
> >>>> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer:
> >>>>> The SabreSD comes with different SoC variants. This patch adds support
> >>>>> for the i.MX6QP based board. the DCD data has been taken from U-Boot
> >>>>> 2021.04
> >>>>>
> >>>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >>>>> ---
> >>>>>
> >>>> [...]
> >>>>> new file mode 100644
> >>>>> index 0000000000..52cc8aa73b
> >>>>> --- /dev/null
> >>>>> +++ b/arch/arm/dts/imx6qp-sabresd.dts
> >>>>> @@ -0,0 +1,42 @@
> >>>>> +/*
> >>>>> + * Copyright 2012 Freescale Semiconductor, Inc.
> >>>>> + * Copyright 2011 Linaro Ltd.
> >>>>> + *
> >>>>> + * The code contained herein is licensed under the GNU General Public
> >>>>> + * License. You may obtain a copy of the GNU General Public License
> >>>>> + * Version 2 or later at the following locations:
> >>>>> + *
> >>>>> + * http://www.opensource.org/licenses/gpl-license.html
> >>>>> + * http://www.gnu.org/copyleft/gpl.html
> >>>>> + */
> >>>>> +
> >>>>> +#include <arm/imx6qp-sabresd.dts>
> >>>>> +
> >>>>> +/ {
> >>>>> +	model = "Freescale i.MX6 Quad SABRE Smart Device Board";
> >>>>> +	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
> >>>>
> >>>> I'm not sure I like this overwriting of the compatible string. AFAICS
> >>>> we don't have any instances for "fsl,imx6qp" compatible checks in
> >>>> either Barebox or Linux kernel, so it shouldn't cause any immediate
> >>>> damage, but this still feels wrong.
> >>>
> >>> It's overwritten with the same strings as the included upstream dts has.
> >>> Anyway, as you say overwriting them here seems wrong. I removed it.
> >>
> >> You had me confused for bit here, so I just checked and the compatible
> >> in the included upstream dts is different, as expected:
> >>
> >> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp";
> >>
> >> So now that you removed those lines, does you board file need fixing
> >> for the different compatibles?
> > 
> > My board works fine (bootspec-wise) with the dropped compatible.
> 
> What's the state of this patch, Sascha?

I just sent out v3.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-05-26  7:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 13:16 [PATCH 1/2] ARM: i.MX: Update sabresdb dcd data from U-Boot Sascha Hauer
2021-04-15 13:16 ` [PATCH 2/2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant Sascha Hauer
2021-04-15 14:03   ` [PATCH v2] " Sascha Hauer
2021-04-15 14:59     ` Lucas Stach
2021-04-15 15:12       ` Sascha Hauer
2021-04-15 15:31         ` Lucas Stach
2021-04-22 15:14           ` Bastian Krause
2021-05-25  8:54             ` Bastian Krause
2021-05-26  7:18               ` Sascha Hauer
2021-05-26  7:18           ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git